From: "Jens Rehsack" <rehsack@gmail.com>
To: Otavio Salvador <otavio.salvador@ossystems.com.br>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>,
Anuj Mittal <anuj.mittal@intel.com>,
Khem Raj <raj.khem@gmail.com>
Subject: Re: [OE-core][PATCH v3] initscripts/init-system-helpers: fix mountnfs.sh dependency
Date: Tue, 5 May 2020 19:20:57 +0200 [thread overview]
Message-ID: <0D58E413-393E-4696-903D-991F32FBFFC7@gmail.com> (raw)
In-Reply-To: <CAP9ODKqkU3YNumNOLbknsFKucMbf1Xsc=niR4MFFk1dQt23-PA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2236 bytes --]
> Am 05.05.2020 um 16:56 schrieb Otavio Salvador <otavio.salvador@ossystems.com.br>:
>
> On Tue, May 5, 2020 at 10:43 AM Jens Rehsack <rehsack@gmail.com> wrote:
>>> Am 04.05.2020 um 16:21 schrieb Otavio Salvador <otavio.salvador@ossystems.com.br>:
>>>
>>> On Mon, May 4, 2020 at 11:10 AM Jens Rehsack <rehsack@gmail.com> wrote:
>>>>
>>>> With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
>>>> Author: Yue Tao <Yue.Tao@windriver.com>
>>>> Date: Fri May 25 10:48:08 2018 +0800
>>>>
>>>> initscripts: Avoid starting rpcbind daemon twice
>>>>
>>>> Check the status before start it to avoid duplicates.
>>>>
>>>> the use of a script {/usr/sbin/}service is introduced - maybe earlier
>>>> provided by systemd, nowadays mostly by init-system-helpers from
>>>> debian project.
>>>>
>>>> For the very first shot, maybe discussions and improvements based
>>>> on that script collection, use just the init-system-helpers-service
>>>> in initscripts/mountnfs.sh to avoid problems mounting NFS in later
>>>> boot stage.
>>>>
>>>> Signed-off-by: Jens Rehsack <sno@netbsd.org>
>>> ...
>>>> +RDEPENDS_${PN}-update-rc.d = "perl"
>>>
>>> Can't it be replaced? using perl here is not nice.
>>
>> Be careful :P
>
> Everyone has the right to do bad choices in life ;-P
/me nods
But comparing to up-river alternatives, there isn't much better :)
>> Seriously - it uses perl only for it's update-rc.d (which I didn't ripped off
>> to give community a chance to discuss it). Generally - especially with the
>> runit, s6, openrc ... in mind - we have to grow from there anyway and I like
>> our current update-rc.d implementation anyway.
>>
>> But I would like then to have a 2nd commit (for documentation purposes) to
>> kill it or we just provide it and let people choose to use this one over
>> meta/recipes-core/update-rc.d
>
> Generally, I'd prefer to not give the option as it causes more
> troubles for supporting it in future. I am totally fine with it being
> dropped on a second commit for sure.
What do others (Richard, Anuj, Khem) say?
And - making a patch series from that or let someone else kicking it?
Cheers
--
Jens Rehsack - rehsack@gmail.com
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 849 bytes --]
prev parent reply other threads:[~2020-05-05 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 14:10 [OE-core][PATCH v3] initscripts/init-system-helpers: fix mountnfs.sh dependency Jens Rehsack
2020-05-04 14:21 ` Otavio Salvador
2020-05-05 13:43 ` Jens Rehsack
2020-05-05 14:56 ` Otavio Salvador
2020-05-05 17:20 ` Jens Rehsack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0D58E413-393E-4696-903D-991F32FBFFC7@gmail.com \
--to=rehsack@gmail.com \
--cc=anuj.mittal@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio.salvador@ossystems.com.br \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox