From: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] python-native: Build with ipv6 enabled
Date: Tue, 26 Sep 2017 12:47:22 -0500 [thread overview]
Message-ID: <0a030b52-93a5-67d2-e7ad-e7492b35f39a@linux.intel.com> (raw)
In-Reply-To: <CAJTo0Lb-RHGu+pPOb+Aa-i7DFi_YsvzuaTy7g8+zXDxOt8FXqg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
On 09/26/2017 12:25 PM, Burton, Ross wrote:
> On 26 September 2017 at 18:23, Alejandro Hernandez
> <alejandro.hernandez@linux.intel.com
> <mailto:alejandro.hernandez@linux.intel.com>> wrote:
>
>> Using EXTRA_OECONF_append gets added to the correct
>> EXTRA_OECONF_class-<target/natve> correctly, otherwise its
>> disregarded.
>
>
> I guess the subtext was
>
> +EXTRA_OECONF_class-native = "\
> + --enable-ipv6=${@bb.utils.contains('DISTRO_FEATURES_NATIVE', 'ipv6',
> 'yes', 'no', d)} \
>
>
> That is totally wrong. In a native recipe, DISTRO_FEATURES has been
> altered based on DISTRO_FEATURES_NATIVE. You don't need to make other
> changes, and I suspect that reverting this chunk means the other
> chunks can also be reverted.
I see your point, seems like I got confused, I just checked and the
resulting EXTRA_OECONF is the same, but I understand why this is
conceptually wrong, I'll send a v2 in a bit.
Thanks!
Alejandro
>
> Ross
>
[-- Attachment #2: Type: text/html, Size: 3495 bytes --]
prev parent reply other threads:[~2017-09-26 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 16:56 [PATCH] python-native: Build with ipv6 enabled Alejandro Hernandez
2017-09-26 17:16 ` Burton, Ross
2017-09-26 17:23 ` Alejandro Hernandez
2017-09-26 17:25 ` Burton, Ross
2017-09-26 17:47 ` Alejandro Hernandez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a030b52-93a5-67d2-e7ad-e7492b35f39a@linux.intel.com \
--to=alejandro.hernandez@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox