Re: [OE-core] [PATCH] tune-cortexa65.inc: Correct TUNE_FEATURES_tune-cortexa65

Martin Jansa
2020-10-12T22:25:02Z

[-- Attachment #1: Type: text/plain, Size: 2448 bytes --]

Good catch, maybe we should require tune-test.sh test for all tune
modifying changes, it catches the issue as the very first tested case:

Testing fake MACHINE fake-cortexa65 for include
conf/machine/include/arm/armv8-2a/tune-cortexa65.inc (1/76)
ERROR: something wrong in openembedded-core/scripts/tune/log.fake-cortexa65

martin@jama:/OE/build/oe-core$ cat
openembedded-core/scripts/tune/log.fake-cortexa65
NOTE: Started PRServer with DBfile: /OE/build/oe-core/cache/prserv.sqlite3,
IP: 127.0.0.1, PORT: 44979, PID: 158972
ERROR: OE-core's config sanity checker detected a potential
misconfiguration.
Either fix the cause of this error or at your own risk disable the
checker (see sanity.conf).
Following is the list of potential problems / advisories:

Toolchain tunings invalid:
Tuning 'cortexa65' has the following errors:
Feature 'cortexa55' is not defined.

Summary: There was 1 ERROR message shown, returning a non-zero exit code.

I'll let it finish in master branch and update
https://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune-test
tomorrow.

On Mon, Oct 12, 2020 at 11:31 PM Peter Kjellerstedt <
peter.kjellerstedt@axis.com> wrote:

> It incorrectly specified "cortexa55" instead of "cortexa65".
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
> meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> index ecf17fbbe7..427e58947f 100644
> --- a/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> +++ b/meta/conf/machine/include/arm/armv8-2a/tune-cortexa65.inc
> @@ -11,6 +11,6 @@ require conf/machine/include/arm/arch-armv8-2a.inc
> # Little Endian base configs
> AVAILTUNES += "cortexa65"
> ARMPKGARCH_tune-cortexa65 = "cortexa65"
> -TUNE_FEATURES_tune-cortexa65 =
> "${TUNE_FEATURES_tune-armv8-2a-crypto} cortexa55"
> +TUNE_FEATURES_tune-cortexa65 =
> "${TUNE_FEATURES_tune-armv8-2a-crypto} cortexa65"
> PACKAGE_EXTRA_ARCHS_tune-cortexa65 =
> "${PACKAGE_EXTRA_ARCHS_tune-armv8-2a-crypto} cortexa65"
> BASE_LIB_tune-cortexa65 = "lib64"
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 3241 bytes --]