Re: [OE-core] [PATCH] tune-cortexa65.inc: Correct TUNE_FEATURES_tune-cortexa65

Martin Jansa
2020-10-15T10:01:48Z

[-- Attachment #1: Type: text/plain, Size: 11493 bytes --]

On Tue, Oct 13, 2020 at 10:44 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Tue, 2020-10-13 at 00:24 +0200, Martin Jansa wrote:
> > Good catch, maybe we should require tune-test.sh test for all tune
> > modifying changes, it catches the issue as the very first tested
> > case:
> >
> > Testing fake MACHINE fake-cortexa65 for include
> > conf/machine/include/arm/armv8-2a/tune-cortexa65.inc (1/76)
> > ERROR: something wrong in openembedded-core/scripts/tune/log.fake-
> > cortexa65
> >
> > martin@jama:/OE/build/oe-core$ cat openembedded-
> > core/scripts/tune/log.fake-cortexa65
> > NOTE: Started PRServer with DBfile: /OE/build/oe-
> > core/cache/prserv.sqlite3, IP: 127.0.0.1, PORT: 44979, PID: 158972
> > ERROR: OE-core's config sanity checker detected a potential
> > misconfiguration.
> > Either fix the cause of this error or at your own risk disable
> > the checker (see sanity.conf).
> > Following is the list of potential problems / advisories:
> >
> > Toolchain tunings invalid:
> > Tuning 'cortexa65' has the following errors:
> > Feature 'cortexa55' is not defined.
> >
> >
> > Summary: There was 1 ERROR message shown, returning a non-zero exit
> > code.
> >
> > I'll let it finish in master branch and update
> >
> https://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/tune-test
> > tomorrow.
>
> Could we turn tune-test.sh into something in oe-selftest? That way it
> would be tested on the infrastructure automatically...
>

It would be definitely better, this shell script is quite ugly, old and
slow, It doesn't even use bitbake server which should really help in this
case (it just calls "bitbake -e" for every combination of tune file and
AVAILTUNES for it). It might also be affected by ARM_INSTRUCTION_SET
setting in the distro, so in theory we should run most arm tunes twice.

My previous test was testing only the "neon-vfpv4" tunes, because that was
probably the last thing I've modified few years ago.

Yesterday I've noticed it and removed this filter .. and it's still
running, now at:
Testing DEFAULTTUNE armv7a-vfpv3 (45/145) for fake MACHINE fake-cortexa53
(33/76)

which means 45th DEFAULTTUNE from 145 on 33rd MACHINE from 76.. hopefully
after it finishes all these cortex* variants it will get
significantly faster, because other tune files don't have so many
AVAILTUNES.

Sofar it found following issues (not all of them are from new tune files
from Jon):

scripts/tune/log.fake-cortexa15.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa15) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa17.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa17) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa32.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_cortexa32) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa32.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa32) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa34.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_cortexa34) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa34.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa34) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa35.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_cortexa35) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa35.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa35) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa5.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa5) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa65.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_cortexa65) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa65ae.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_cortexa65ae) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa65ae.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa65ae) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa65.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa65) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa73.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_cortexa73) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa73.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa73) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa73-cortexa35.aarch64_be: Error, the
PACKAGE_ARCHS variable (all any noarch aarch64_be fake_cortexa73_cortexa35)
for DEFAULTTUNE (aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa73-cortexa35.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa73_cortexa35) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa75.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_cortexa75) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa75.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa75) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa75-cortexa55.aarch64_be: Error, the
PACKAGE_ARCHS variable (all any noarch aarch64_be fake_cortexa75_cortexa55)
for DEFAULTTUNE (aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa75-cortexa55.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa75_cortexa55) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa76.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_cortexa76) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa76ae.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_cortexa76ae) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa76ae.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa76ae) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa76.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa76) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa76-cortexa55.aarch64_be: Error, the
PACKAGE_ARCHS variable (all any noarch aarch64_be fake_cortexa76_cortexa55)
for DEFAULTTUNE (aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa76-cortexa55.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa76_cortexa55) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-cortexa77.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_cortexa77) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-cortexa77.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_cortexa77) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-ep9312: Error, the PACKAGE_ARCHS variable (all any
noarch arm armv4 armv4t ep9312 fake_ep9312) for DEFAULTTUNE (ep9312) does
not contain TUNE_PKGARCH (ep9312t).
scripts/tune/log.fake-mips-24k.mips64el-o32: Error, the PACKAGE_ARCHS
variable contains duplicates. The following archs are listed more than
once: mips64el-o32
scripts/tune/log.fake-mips-74k.mips64el-o32: Error, the PACKAGE_ARCHS
variable contains duplicates. The following archs are listed more than
once: mips64el-o32
scripts/tune/log.fake-neoversee1.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_neoversee1) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-neoversee1.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_neoversee1) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-neoversen1.aarch64_be: Error, the PACKAGE_ARCHS
variable (all any noarch aarch64_be fake_neoversen1) for DEFAULTTUNE
(aarch64_be) does not contain TUNE_PKGARCH (aarch64_be_be).
scripts/tune/log.fake-neoversen1.armv7atb-vfpv4d16: Error, the
PACKAGE_ARCHS variable (all any noarch
${PACKAGE_EXTRA_ARCHS_tune-armv7atb-vfpv4d16} fake_neoversen1) for
DEFAULTTUNE (armv7atb-vfpv4d16) does not contain TUNE_PKGARCH
(armv7at2b-vfpv4d16).
scripts/tune/log.fake-riscv.riscv32nf: Error, the PACKAGE_ARCHS variable
(all any noarch riscv32nf fake_riscv) for DEFAULTTUNE (riscv32nf) does not
contain TUNE_PKGARCH (riscv32).
scripts/tune/log.fake-riscv.riscv64nf: Error, the PACKAGE_ARCHS variable
(all any noarch riscv64nf fake_riscv) for DEFAULTTUNE (riscv64nf) does not
contain TUNE_PKGARCH (riscv64).
scripts/tune/log.fake-supersparc: Error, the PACKAGE_ARCHS variable (all
any noarch ${PACKAGE_EXTRA_ARCHS_tune-${DEFAULTTUNE}} fake_supersparc) for
DEFAULTTUNE (None) does not contain TUNE_PKGARCH (supersparc).Toolchain
tunings invalid:

[-- Attachment #2: Type: text/html, Size: 12314 bytes --]