From: akuster808 <akuster808@gmail.com>
To: Otavio Salvador <otavio.salvador@ossystems.com.br>,
Javier Viguera <javier.viguera@digi.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [morty backport][PATCH 1/2] tcf-agent: kill with USR2 in systemd stop
Date: Wed, 15 Nov 2017 15:34:39 -0800 [thread overview]
Message-ID: <0c3d099a-e0a3-33fb-7e80-ed0cf12b7ca2@gmail.com> (raw)
In-Reply-To: <CAP9ODKoW7rQPc_fE9tm9ydfiz9ZdawE+b9yQEu4pTkHX=pSmow@mail.gmail.com>
On 11/15/2017 12:37 PM, Otavio Salvador wrote:
> On Tue, Nov 14, 2017 at 5:56 PM, Javier Viguera <javier.viguera@digi.com> wrote:
>> From: Martin Kelly <mkelly@xevo.com>
>>
>> tcf-agent ignores SIGTERM, so upstream uses USR2 instead. This issue was noticed
>> by Jan Kiszka and Brian Avery around the same time:
>>
>> https://patchwork.openembedded.org/patch/139546/
>> https://patchwork.openembedded.org/patch/139560/
>>
>> However, these patches fixed only the init scripts, not the systemd service
>> file. This patch fixes the systemd file.
>>
>> Signed-off-by: Martin Kelly <mkelly@xevo.com>
>> Signed-off-by: Ross Burton <ross.burton@intel.com>
>> Signed-off-by: Javier Viguera <javier.viguera@digi.com>
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
>
> Please also queue this for rocko backport. It seems a good fix.
rocko released with this fix.
http://cgit.openembedded.org/openembedded-core/commit/meta/recipes-devtools/tcf-agent?h=rocko&id=4f8ed1b3bf676a58055ebe01184b3594459a4118
>
next prev parent reply other threads:[~2017-11-15 23:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 19:56 [morty backport][PATCH 0/2] tcf-agent fixes Javier Viguera
2017-11-14 19:56 ` [morty backport][PATCH 1/2] tcf-agent: kill with USR2 in systemd stop Javier Viguera
2017-11-15 20:37 ` Otavio Salvador
2017-11-15 23:34 ` akuster808 [this message]
2017-11-14 19:56 ` [morty backport][PATCH 2/2] tcf-agent: Fix daemon termination Javier Viguera
2017-11-15 17:29 ` [morty backport][PATCH 0/2] tcf-agent fixes Martin Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c3d099a-e0a3-33fb-7e80-ed0cf12b7ca2@gmail.com \
--to=akuster808@gmail.com \
--cc=javier.viguera@digi.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio.salvador@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox