Re: [PATCH v2 1/5] devtool: ide_sdk: Use bitbake's python3 for generated scripts

adrian.freihofer
2024-02-20T09:03:24Z

On Mon, 2024-02-19 at 17:55 +0100, Enguerrand de Ribaucourt wrote:
> The generated scripts use the sys.path configuration found inside
> bitbake. It can be a different python version than the one used on
> the
> host through the IDE.
>
> For instance, when running the generated script
> deploy_target_cmake-example-core2-64 from an eSDK generated on
> another
> machine, I got the following exception:
>     AssertionError: SRE module mismatch
>
> We need to match the sys.executable to the sys.path.
>
> Signed-off-by: Enguerrand de Ribaucourt
> <enguerrand.de-ribaucourt@savoirfairelinux.com>
> ---
>  scripts/lib/devtool/ide_sdk.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/devtool/ide_sdk.py
> b/scripts/lib/devtool/ide_sdk.py
> index 3986dc1436a..14679744807 100755
> --- a/scripts/lib/devtool/ide_sdk.py
> +++ b/scripts/lib/devtool/ide_sdk.py
> @@ -750,7 +750,7 @@ class RecipeModified:
>          does not need to start a bitbake server. All information
> from tinfoil
>          is hard-coded in the generated script.
>          """
> -        cmd_lines = ['#!/usr/bin/env python3']
> +        cmd_lines = ['#!%s' % str(sys.executable)]
>          cmd_lines.append('import sys')
>          cmd_lines.append('devtool_sys_path = %s' % str(sys.path))
>          cmd_lines.append('devtool_sys_path.reverse()')

LGTM.

Adrian