Re: [OE-core] [PATCH v3] sanity: test for c toolchain

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sat, 2025-01-18 at 13:01 +0100, Christos Gavros via lists.openembedded.org wrote:
> Users reported issues caused by missing the right libstdc++-version-dev.
> A new function 'check_c_toolchain' added in sanity.bbclass to test linking libstdc++
> Fixes [YOCTO #15712]
> 
> Signed-off-by: Christos Gavros <gavrosc@yahoo.com>
> Reviewed-by: Yoann Congal <yoann.congal@smile.fr>
> ---
> v2->v3
> * whitespaces are removed
> * the format for reference to the bug is fixed
> * 'Reviewed-by' tag is added
> ---
>  meta/classes-global/sanity.bbclass | 40 ++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)

This is looking really good thanks!

The one thing left which probably needs tweaking is testing this on
every build. I think that is a bit too much overhead and we should do
this in check_sanity_version_change().

The reason being that once builds are working on a given system we
probably don't need to check again. If people do run into issues, they
will probably test a clean builddir and at that point the error would
also show up.

If you could send a v4 with that small tweak, I think it looks good to
merge, thanks.

Cheers,

Richard