From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id BE80D7DEBB for ; Tue, 14 May 2019 03:41:24 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id x4E3fLFg017854 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 13 May 2019 20:41:21 -0700 (PDT) Received: from [128.224.162.179] (128.224.162.179) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.439.0; Mon, 13 May 2019 20:41:20 -0700 To: Khem Raj References: <20190513095255.157287-1-kai.kang@windriver.com> <20190513095255.157287-2-kai.kang@windriver.com> From: Kang Kai Message-ID: <0dad34dc-9c84-0320-e03c-db58a4943482@windriver.com> Date: Tue, 14 May 2019 11:41:01 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/1] webkitgtk: fix compile error for arm64 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 May 2019 03:41:24 -0000 Content-Type: multipart/alternative; boundary="------------C09284007C35A989BB3F7BDB" Content-Language: en-US --------------C09284007C35A989BB3F7BDB Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 2019/5/13 下午11:43, Khem Raj wrote: > Can you test this on say rpi3 in 64bit mode and see all is ok ? It is ok to build 64-bit rpi3 from layer git://git.yoctoproject.org/meta-raspberrypi with configurations: MACHINE = "raspberrypi3-64" LICENSE_FLAGS_WHITELIST_append = " commercial" Regards, Kai > > On Mon, May 13, 2019 at 2:53 AM > wrote: > > From: Kai Kang > > > It removes function JSC::AssemblerBuffer::data() for ARM64 in commit > https://trac.webkit.org/changeset/236589/webkit. But the function is > still required by Cortex A53 and fails to compile for arm64: > > | > .../tmp/work/aarch64-poky-linux/webkitgtk/2.24.1-r0/webkitgtk-2.24.1/Source/JavaScriptCore/assembler/ARM64Assembler.h:3769:100: > error: 'class JSC::AssemblerBuffer' has no member named 'data' > |     if > (UNLIKELY((*reinterpret_cast_ptr(reinterpret_cast_ptr(m_buffer.data()) > + m_buffer.codeSize() - sizeof(int32_t)) & 0x0a000000) == 0x08000000)) > > Not set WTF_CPU_ARM64_CORTEXA53 for arm64 to fix the failure. > > Signed-off-by: Kai Kang > > --- >  meta/recipes-sato/webkit/webkitgtk_2.24.1.bb > | 2 -- >  1 file changed, 2 deletions(-) > > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb > > b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb > > index 771a893a6b..a57a3c058c 100644 > --- a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb > > +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb > > @@ -98,8 +98,6 @@ EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF " >  EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF " >  EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF " > > -EXTRA_OECMAKE_append_aarch64 = " -DWTF_CPU_ARM64_CORTEXA53=ON" > - >  # JIT not supported on MIPS either >  EXTRA_OECMAKE_append_mipsarch = " -DENABLE_JIT=OFF " > > -- > 2.20.0 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- Kai Kang --------------C09284007C35A989BB3F7BDB Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
On 2019/5/13 下午11:43, Khem Raj wrote:
Can you test this on say rpi3 in 64bit mode and see all is ok ?

It is ok to build 64-bit rpi3 from layer git://git.yoctoproject.org/meta-raspberrypi
with configurations:

MACHINE = "raspberrypi3-64"                                                                                                                      
LICENSE_FLAGS_WHITELIST_append = " commercial"

Regards,
Kai



On Mon, May 13, 2019 at 2:53 AM <kai.kang@windriver.com> wrote:
From: Kai Kang <kai.kang@windriver.com>

It removes function JSC::AssemblerBuffer::data() for ARM64 in commit
https://trac.webkit.org/changeset/236589/webkit. But the function is
still required by Cortex A53 and fails to compile for arm64:

| .../tmp/work/aarch64-poky-linux/webkitgtk/2.24.1-r0/webkitgtk-2.24.1/Source/JavaScriptCore/assembler/ARM64Assembler.h:3769:100: error: 'class JSC::AssemblerBuffer' has no member named 'data'
|     if (UNLIKELY((*reinterpret_cast_ptr<int32_t*>(reinterpret_cast_ptr<char*>(m_buffer.data()) + m_buffer.codeSize() - sizeof(int32_t)) & 0x0a000000) == 0x08000000))

Not set WTF_CPU_ARM64_CORTEXA53 for arm64 to fix the failure.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.24.1.bb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
index 771a893a6b..a57a3c058c 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.24.1.bb
@@ -98,8 +98,6 @@ EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
 EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "
 EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "

-EXTRA_OECMAKE_append_aarch64 = " -DWTF_CPU_ARM64_CORTEXA53=ON"
-
 # JIT not supported on MIPS either
 EXTRA_OECMAKE_append_mipsarch = " -DENABLE_JIT=OFF "

--
2.20.0

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


-- 
Kai Kang
--------------C09284007C35A989BB3F7BDB--