Re: [OE-core][dunfell 23/25] kernel.bbclass: run do_symlink_kernsrc before do_patch

["Rasmus Villemoes" <rasmus.villemoes@prevas.dk>]

On 16/09/2020 17.18, Steve Sakoman wrote:
> Since there is an upcoming dunfell release and we don't have a fix for
> this issue I am going to revert this patch.
> 
> When it is fixed in master I will reconsider taking this patch and the
> fix for dunfell.

Sorry for not seeing this sooner, and for the bug in the first place.

However, looking into externalsrc.bbclass, isn't the bug there,
considering the "if we delete do_patch, do_unpack doesn't run" fixup
done - kernel-yocto.bbclass has a similar fixup for do_kernel_configme.
Why doesn't that class just set [noexec]=1 instead of deleting the tasks
outright, killing all those random fixups?

But if that's too invasive, I suppose just ordering the symlink task
before both patch and configure should work, i.e.

--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -172,7 +172,7 @@ python do_symlink_kernsrc () {
             shutil.move(s, kernsrc)
             os.symlink(kernsrc, s)
 }
-addtask symlink_kernsrc before do_patch after do_unpack
+addtask symlink_kernsrc before do_patch do_configure after do_unpack

 inherit kernel-arch deploy




Rasmus