Re: [PATCH 5/5] hdparm: 9.48 -> 9.50

[Robert Yang <liezhi.yang@windriver.com>]

Thanks, updated in the repo:

   git://git.openembedded.org/openembedded-core-contrib rbt/pu
   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/pu

Robert Yang (5):
   debianutils: 4.8 -> 4.8.1
   mklibs-native: 0.1.41 -> 0.1.43
   quilt: 0.64 -> 0.65
   guile: 2.0.12 -> 2.0.13
   hdparm: 9.48 -> 9.50



Author: Robert Yang <liezhi.yang@windriver.com>
Date:   Tue Dec 20 03:09:45 2016 +0000

     hdparm: 9.48 -> 9.50

     Remove "-e MAKEFLAGS=" from EXTRA_OEMAKE to fix:
     ERROR: hdparm-9.50-r0 do_package: QA Issue: File '/sbin/hdparm.hdparm' from 
hdparm was already stripped, this will prevent future debugging! [already-stripped]
     ERROR: hdparm-9.50-r0 do_package: Fatal QA errors found, failing task.

     The "-e MAKEFLAGS=" would cause submake can't get vars from environment,
     The git log said that it was added for fixing a QA warning, but
     everything is OK after remove it now.

     Signed-off-by: Robert Yang <liezhi.yang@windriver.com>

diff --git a/meta/recipes-extended/hdparm/hdparm_9.48.bb 
b/meta/recipes-extended/hdparm/hdparm_9.50.bb
similarity index 81%
rename from meta/recipes-extended/hdparm/hdparm_9.48.bb
rename to meta/recipes-extended/hdparm/hdparm_9.50.bb
index cd85776cf8f..f89c30e4dda 100644
--- a/meta/recipes-extended/hdparm/hdparm_9.48.bb
+++ b/meta/recipes-extended/hdparm/hdparm_9.50.bb
@@ -20,12 +20,12 @@ FILES_wiper = "${bindir}/wiper.sh"

  RDEPENDS_wiper = "bash gawk stat"

-SRC_URI = "${SOURCEFORGE_MIRROR}/hdparm/${BP}.tar.gz "
+SRC_URI = "${SOURCEFORGE_MIRROR}/hdparm/${BP}.tar.gz"

-SRC_URI[md5sum] = "213efdbe7471fad3408198918e164354"
-SRC_URI[sha256sum] = 
"ce97b4a71cb04146f54cf6f69787e7f97ddfda9836dc803b459d3b3df3a4fbee"
+SRC_URI[md5sum] = "d380062ad6c4b40076736efbb640f1f5"
+SRC_URI[sha256sum] = 
"0892b44bd817c251264a24f6ecbbb010958033e0395d2030f25f1c5608ac780e"

-EXTRA_OEMAKE = '-e MAKEFLAGS= STRIP="echo"'
+EXTRA_OEMAKE = 'STRIP="echo" LDFLAGS="${LDFLAGS}"'

  inherit update-alternatives


// Robert

On 12/22/2016 09:34 PM, Andreas Oberritter wrote:
> On 22.12.2016 04:14, Robert Yang wrote:
>> On 12/22/2016 11:09 AM, Andreas Oberritter wrote:
>>> On 22.12.2016 03:47, Robert Yang wrote:
>>>> On 12/21/2016 09:27 PM, Andre McCurdy wrote:
>>>>> Passing LDFLAGS on the make command line might be a cleaner solution
>>>>> than patching the Makefile.
>>>>
>>>> We can't do that since there is a "-e MAKEFLAGS=" in EXTRA_OEMAKE,
>>>> and its
>>>> Makefile is:
>>>>
>>>> all:
>>>>     make -j2 hdparm
>>>>
>>>> hdparm: hdparm.h sgio.h $(OBJS)
>>>>     $(CC) $(LDFLAGS) -o hdparm $(OBJS)
>>>>     $(STRIP) hdparm
>>>>
>>>> The "make -j2 hdparm" doesn't pass any env vars to sub make since
>>>> MAKEFLAGS=,
>>>> so that need use weak assignment "?=" here.
>>>
>>> You don't need to use target 'all'. Try this:
>>>
>>> do_compile() {
>>>     oe_runmake hdparm
>>> }
>>
>> I know this will work, but "make hdparm" rather than "all" may cause other
>> issues in the future when hdparm gets ugpraded, for example, "all" doesn't
>> only contain "hdmarm". And do we have really have to add a do_compile()
>> here ?
>
> It's certainly easier to delete do_compile in a future version's recipe
> than regenerating patches. hdparm is looking for a new maintainer, btw.
>
> 'hdparm' has been the only target built by 'all' since at least version
> 3.1, which dates back to 1996.
>
> Regards,
> Andreas
>