Re: [PATCH V3] Add file information to package information window

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Thursday 04 April 2013 11:20:34 Andrei Dinu wrote:
> Removed the package files parsing routine from the
> packageinfo.bbclass file and added it to the
> package.bbclass file.
> 
> Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
> ---
>  meta/classes/package.bbclass     |   12 ++++++++++++
>  meta/classes/packageinfo.bbclass |   20 --------------------
>  2 files changed, 12 insertions(+), 20 deletions(-)
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 3479947..e859a65 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -1130,6 +1130,15 @@ python emit_pkgdata() {
>      workdir = d.getVar('WORKDIR', True)
> 
>      for pkg in packages.split():
> +        items = {}
> +        for files_list in pkgfiles[pkg]:
> +             item_name = os.path.basename(files_list)
> +             item_path = files_list.split(os.path.basename(files_list))[0]
[:-1] 

There is os.path.dirname() for this as well; alternatively you could use 
os.path.split() to get both at the same time.

> +             if item_path not in items:
> +                 items[item_path] = []
> +                 items[item_path].append(item_name)
> +             else:
> +                 items[item_path].append(item_name)

This could be simplified to:
             if item_path not in items:
                 items[item_path] = []
             items[item_path].append(item_name)

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre