Re: [PATCH] package: disable renamed dependency error if allarch is overridden

["Oleksandr Hnatiuk" <ohnatiuk@cisco.com>]

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

I will have to check why such packages are included.

However, consider the following. Here are all the parts of this issue:
* a packagegroup explicitly inherits packagegroup and nativesdk classes
* same packagegroup depends on a package which is subject to dynamic package renaming
* packagegroup.bbclass unconditionally (because of immediate expansion) inherits allarch.bbclass
* nativesdk.bbclass overrides PACKAGE_ARCH with correct value, preventing code in allarch.bbclass from executing (because allarch.bbclass tests this variable before doing anything)
* bitbake raises an allarch-specific error by testing whether allarch was ever inherited instead of whether any of its code was executed (see 4)

Regardless of whether 2 is justified, the behavior in 3 and/or 5 is seems incorrect.
allarch.bbclass is unique in that we cannot test if it is really used without checking the value of PACKAGE_ARCH.
If we simply check via bb.data.inherits_class, we get false positives (again, see step 4).
Thus, it is incorrect to issue an error for packagegroups that inherit allarch without also verifying that they are actually allarch via PACKAGE_ARCH.
Without this extra check, the error is produced for packagegroups for which code in allarch.bbclass was never and will never be executed.

[-- Attachment #2: Type: text/html, Size: 1433 bytes --]