Re: [PATCHv3] cmake.bbclass: pass mandatory compiler flags through CMAKE_<LANG>_COMPILER_ARG1

[Nikolai Merinov <n.merinov@inango-systems.com>]

Hi Richard,

Can you help me to understand how I can reproduce this issue on local build? I want to try to debug it.

Regards,
Nikolai

----- Original Message -----
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: "n merinov" <n.merinov@inango-systems.com>
Cc: "openembedded-core" <openembedded-core@lists.openembedded.org>
Sent: Tuesday, June 25, 2019 1:03:11 PM
Subject: Re: [OE-core] [PATCHv3] cmake.bbclass: pass mandatory compiler flags through CMAKE_<LANG>_COMPILER_ARG1

On Mon, 2019-06-24 at 13:24 +0300, Nikolai Merinov via Openembedded-
core wrote:
> Patch updated with "Signed-off-by" field as required by automatic
> checks.
> 
> ----- Original Message -----
> From: "openembedded-core" <openembedded-core@lists.openembedded.org>
> To: "Khem Raj" <raj.khem@gmail.com>
> Cc: "openembedded-core" <openembedded-core@lists.openembedded.org>
> Sent: Thursday, June 20, 2019 7:16:07 PM
> Subject: [OE-core] [PATCHv2] cmake.bbclass: pass mandatory compiler
> flags through CMAKE_<LANG>_COMPILER_ARG1
> 
> Hi,
> 
> Updated patch for the current "master" branch is attached.
> 
> > have you also tried building SDK and see if these changes are
> > reflected in SDK as well ?
> 
> I checked that the changes reflected in the Extensible SDK for the
> "core-image-sato" image of the poky.
> 
> Regards,
> Nikolai
> 
> ----- Original Message -----
> From: "Khem Raj" <raj.khem@gmail.com>
> To: "n merinov" <n.merinov@inango-systems.com>, "openembedded-core" <
> openembedded-core@lists.openembedded.org>
> Sent: Tuesday, May 21, 2019 1:41:46 AM
> Subject: Re: [OE-core] [PATCH] cmake.bbclass: pass mandatory compiler
> flags through CMAKE_<LANG>_COMPILER_ARG1
> 
> On 5/14/19 8:04 AM, Nikolai Merinov wrote:
> > The CMake takes mandatory compiler arguments from the following
> > variables:
> > - CMAKE_SYSROOT -- path to sysroot that should be passed to
> > compiler.
> > - CMAKE_<LANG>_COMPILER_TARGET -- target architecture, used for
> > compilers
> >    that supports several targets through command line options.
> >    e.g. "clang --target ${CMAKE_C_COMPILER_TARGET}".
> > - CMAKE_<LANG>_COMPILER_EXTERNAL_TOOLCHAIN -- path to external
> > toolchain,
> >    used for compilers that support build with external toolchain.
> >    e.g. "clang --gcc-toolchain
> > ${CMAKE_C_COMPILER_EXTERNAL_TOOLCHAIN}".
> > - CMAKE_<LANG>_COMPILER_ARG1 -- other mandatory arguments to a
> > compiler
> >    command.
> > 
> > CMAKE_<LANG>_COMPILER_ARG1 is the most suitable variable to pass
> > mandatory
> > arguments, that belongs to CC variable with other build systems, to
> > a
> > compiler.
> > 
> > Additionally usage of CMAKE_<LANG>_COMPILER_ARG1 instead of
> > CMAKE_<LANG>_FLAGS reduce the risk that a variable can be overrided
> > by
> > CMakeLists.txt files.
> 
I'm afraid this caused a number of build failures and selftest issues:

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/236

(most of the selftest failures there for example are from this, as is 
https://autobuilder.yoctoproject.org/typhoon/#/builders/69/builds/746/steps/7/logs/step7b
)

Cheers,

Richard