Openembedded Core Discussions
 help / color / mirror / Atom feed
From: richard.purdie@linuxfoundation.org
To: Joshua Watt <jpewhacker@gmail.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] classes/testsdk: Split implementation into classes
Date: Thu, 15 Nov 2018 22:48:31 +0000	[thread overview]
Message-ID: <1060b6d3b60e6c821fff8b7cf75fa3da25fcefba.camel@linuxfoundation.org> (raw)
In-Reply-To: <32da8c27357053bf0e1eac4169125a130ae3a24f.camel@gmail.com>

On Thu, 2018-11-15 at 16:28 -0600, Joshua Watt wrote:
> 
> ---- classes/testsdk(ext)?-oecore.bbclass ----
> 
> python do_testsdk() {
>     from oeqa.sdk.testsdk import TestSDK
>     t = TestSDK(d)
>     t.run()
> }
> 
> ----
> 
> It might make things a little more clear if I describe the end game;
> I
> would like to provide a different class to implement the MinGW SDK
> tests. This would be done by adding the following to the MinGW SDK
> machine.conf file (mingw32-common.inc):
> 
>  TESTSDK_CLASSES = "testsdk-mingw"
> 
> Then, adding a new class in meta-mingw
> 
> ---- classes/testsdk-mingw.bbclass ----
> 
> python do_testsdk() {
>     from oeqa.sdk.testsdkmingw import TestSDKMinGW
>     t = TestSDKMinGW(d)
>     t.run()
> }
> 
> ----
> 
> AFAICT, this is pretty similar to how the package managers are
> working.
> 
> Did you had something else in mind?

We're thinking along similar lines but in pseudo-code I was thinking
something more like:

SDKCLASSNAME ??= "default"

python do_testsdk() {
     sdkclass = d.getVar("SDKCLASSNAME")
     from oeqa.sdk.testsdkmingw import sdkclass
     t = sdkclass(d)
     t.run()
}
 

as there should be some way to structure this so we don't need so many
bbclass files...

Cheers,

Richard



  reply	other threads:[~2018-11-15 22:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 19:14 [PATCH] classes/testsdk: Split implementation into classes Joshua Watt
2018-11-15 19:40 ` Richard Purdie
2018-11-15 22:28   ` Joshua Watt
2018-11-15 22:48     ` richard.purdie [this message]
2018-11-18 19:19 ` [PATCH v2] " Joshua Watt
2018-11-19 14:25   ` Richard Purdie
2018-11-19 16:33     ` Joshua Watt
2018-11-19 18:11   ` [PATCH v3] " Joshua Watt
2018-11-18 19:33 ` ✗ patchtest: failure for classes/testsdk: Split implementation into classes (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1060b6d3b60e6c821fff8b7cf75fa3da25fcefba.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jpewhacker@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox