From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chuck Wolber <chuckwolber@gmail.com>
Cc: thune.a.tran@boeing.com,
openembedded-core@lists.openembedded.org,
Chuck Wolber <chuck.wolber@boeing.com>
Subject: Re: [OE-core] [PATCH] oeqa/sdk/sdktest: Add test discovery across layers
Date: Thu, 17 Apr 2025 12:04:10 +0100 [thread overview]
Message-ID: <1264db75faf2ae16362f1f05ea2b6b77e0fb7616.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAB=6tBQsqNJBqFsocxDQM9sOwz5S3w5HqkOO2cLuvH8OmSQ4kA@mail.gmail.com>
On Wed, 2025-04-16 at 21:39 -0700, Chuck Wolber wrote:
> On Wed, Apr 16, 2025 at 3:07 PM Richard Purdie via
> lists.openembedded.org
> <richard.purdie=linuxfoundation.org@lists.openembedded.org> wrote:
>
> %< SNIP $<
> >
> > I suspect this causes some regressions in our automated testing
> > unfortunately:
> >
> > buildtools:
> > https://autobuilder.yoctoproject.org/valkyrie/#/builders/43/builds/1396
> >
> > meta-mingw:
> > https://autobuilder.yoctoproject.org/valkyrie/#/builders/7/builds/1430
> >
>
>
> Would it make more sense to add
> self.context_executor_class.default_cases
> to the list of paths returned by get_sdk_paths?
meta/recipes-core/meta/buildtools-tarball.bb does:
cases_path = os.path.join(os.path.abspath(os.path.dirname(oeqa.sdk.testsdk.__file__)), d.getVar("TESTSDK_CASES"))
testsdk.context_executor_class.default_cases = cases_path
mingw does things in a different place, setting:
default_cases = [os.path.join(os.path.abspath(os.path.dirname(__file__)), 'cases')]
in meta-mingw/lib/oeqa/sdkmingw/contex.py
I think we need to add something which represents the name of the
directory for cases, i.e. "sdk", "sdkming", "sdk/buildtools-cases" and
then allow this to be passed into your function so regardless, it
allows customisation within a layer.
Just adding default cases to anything in the layer is going to always
add the layer's test cases which isn't what we want (i.e. your layer
would add to buildtools, mingw and sdk).
Cheers,
Richard
next prev parent reply other threads:[~2025-04-17 11:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 16:41 [PATCH] oeqa/sdk/sdktest: Add test discovery across layers Thune Tran
2025-04-16 17:23 ` [OE-core] " Gyorgy Sarvari
2025-04-16 20:54 ` Tran (US), Thune A
2025-04-16 21:16 ` Gyorgy Sarvari
2025-04-16 22:07 ` Richard Purdie
2025-04-17 4:39 ` Chuck Wolber
2025-04-17 10:06 ` Gyorgy Sarvari
2025-04-17 11:04 ` Richard Purdie [this message]
2025-04-17 12:54 ` Tran (US), Thune A
2025-04-17 13:03 ` Richard Purdie
2025-04-17 15:53 ` Tran (US), Thune A
[not found] ` <18372610739395C0.11203@lists.openembedded.org>
2025-04-21 19:21 ` Tran (US), Thune A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264db75faf2ae16362f1f05ea2b6b77e0fb7616.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=chuck.wolber@boeing.com \
--cc=chuckwolber@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=thune.a.tran@boeing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox