Openembedded Core Discussions
 help / color / mirror / Atom feed
From: tom.zanussi@intel.com
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 8/9] qemumachines: make MACHINE_FEATURES append follow qemu.inc include
Date: Tue,  3 Jul 2012 13:10:35 -0500	[thread overview]
Message-ID: <1270ddc19a4f865a6a13e694f0af940ed76f7570.1341338051.git.tom.zanussi@intel.com> (raw)
In-Reply-To: <ef6a9af654411604543f0baf3fb9b366268ba233.1341338051.git.tom.zanussi@intel.com>
In-Reply-To: <cover.1341338051.git.tom.zanussi@intel.com>

From: Tom Zanussi <tom.zanussi@intel.com>

qemu.inc does a straight assign to MACHINE_FEATURES so overwriting the
preceding append to MACHINE_FEATURES, so the MACHINE_FEATURES append
needs to be moved after the include.

This situation came about as a result of commit 71a4bf386:

    qemumachines: Enable xserver-xorg as default xserver

    For qemux86 and qemux86-64 include qemu.inc after defining XSERVER

which missed this side-effect (and maybe others).

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/conf/machine/qemux86-64.conf |    4 ++--
 meta/conf/machine/qemux86.conf    |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/conf/machine/qemux86-64.conf b/meta/conf/machine/qemux86-64.conf
index 2e361a5..998ef60 100644
--- a/meta/conf/machine/qemux86-64.conf
+++ b/meta/conf/machine/qemux86-64.conf
@@ -7,8 +7,6 @@ PREFERRED_PROVIDER_virtual/libgl ?= "mesa-dri"
 
 require conf/machine/include/tune-x86_64.inc
 
-MACHINE_FEATURES += "x86"
-
 KERNEL_IMAGETYPE = "bzImage"
 
 SERIAL_CONSOLE = "115200 ttyS0"
@@ -24,6 +22,8 @@ XSERVER ?= "xserver-xorg \
 
 require conf/machine/include/qemu.inc
 
+MACHINE_FEATURES += "x86"
+
 GLIBC_ADDONS = "nptl"
 GLIBC_EXTRA_OECONF = "--with-tls"
 
diff --git a/meta/conf/machine/qemux86.conf b/meta/conf/machine/qemux86.conf
index ad840c0..57e480c 100644
--- a/meta/conf/machine/qemux86.conf
+++ b/meta/conf/machine/qemux86.conf
@@ -7,8 +7,6 @@ PREFERRED_PROVIDER_virtual/libgl ?= "mesa-dri"
 
 require conf/machine/include/tune-i586.inc
 
-MACHINE_FEATURES += "x86"
-
 KERNEL_IMAGETYPE = "bzImage"
 
 SERIAL_CONSOLE = "115200 ttyS0"
@@ -24,6 +22,8 @@ XSERVER ?= "xserver-xorg \
 
 require conf/machine/include/qemu.inc
 
+MACHINE_FEATURES += "x86"
+
 GLIBC_ADDONS = "nptl"
 GLIBC_EXTRA_OECONF = "--with-tls"
 
-- 
1.7.0.4




  parent reply	other threads:[~2012-07-03 18:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-03 18:10 [PATCH 0/9] perf: enable Perl and Python bindings, and perf TUI tom.zanussi
2012-07-03 18:10 ` [PATCH 1/9] perl: keep original libperl location tom.zanussi
2012-07-03 18:10 ` [PATCH 2/9] perl: add @STAGINGDIR@ for config.sh substitions tom.zanussi
2012-07-03 18:10 ` [PATCH 3/9] perl: use @STAGINGDIR@ in config.sh tom.zanussi
2012-07-03 18:10 ` [PATCH 4/9] perf: enable Python bindings tom.zanussi
2012-07-03 18:10 ` [PATCH 5/9] perf: enable Perl binding tom.zanussi
2012-07-03 18:10 ` [PATCH 6/9] perf: add libexec/perf-core and contents tom.zanussi
2012-07-03 18:10 ` [PATCH 7/9] perf: add perf-scripting MACHINE_FEATURE tom.zanussi
2012-07-04 14:02   ` Richard Purdie
2012-07-04 19:16     ` Tom Zanussi
2012-07-05 13:42       ` Richard Purdie
2012-07-05 13:54         ` Tom Zanussi
2012-07-03 18:10 ` tom.zanussi [this message]
2012-07-03 18:10 ` [PATCH 9/9] perf: add perf-tui MACHINE_FEATURE tom.zanussi
2012-07-05 17:56 ` [PATCH 0/9] perf: enable Perl and Python bindings, and perf TUI Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270ddc19a4f865a6a13e694f0af940ed76f7570.1341338051.git.tom.zanussi@intel.com \
    --to=tom.zanussi@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox