Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Christos Gavros" <gavrosc@yahoo.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] oeqa/selftest: add a newline in local.conf (newbuilddir)
Date: Sat, 22 Feb 2025 23:47:56 -0800	[thread overview]
Message-ID: <12863.1740296876523244699@lists.openembedded.org> (raw)
In-Reply-To: <CAMSfU+7QX_n6+-rYbm9eoLZYA5bbjr7PwAdK=+QkiP2NrX+FPQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

hi

I will change the comment.

Regarding 'None'(NoneType) and ""(str) ,  I don't see any significant difference here but it can be changed.

I considered "f.write" and is simpler as you said but lower in "context.py" is used subprocess to write SSTATE_DIR
and I thought of using the same to keep consistency.

I will wait a bit to see if someone else will comment something and I will submit v2.

Br
Christos

[-- Attachment #2: Type: text/html, Size: 607 bytes --]

      reply	other threads:[~2025-02-23  7:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250222125822.385265-1-gavrosc.ref@yahoo.com>
2025-02-22 12:58 ` [PATCH] oeqa/selftest: add a newline in local.conf (newbuilddir) Christos Gavros
2025-02-22 23:37   ` Yoann Congal
2025-02-23  7:47     ` Christos Gavros [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12863.1740296876523244699@lists.openembedded.org \
    --to=gavrosc@yahoo.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox