Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: poky@yoctoproject.org, Zhai Edwin <edwin.zhai@intel.com>
Subject: Re: [PATCH 03/10] sato-icon-theme: Explictly use "Sato" as gtk icon theme
Date: Thu, 03 Mar 2011 23:24:28 +0000	[thread overview]
Message-ID: <1299194668.17567.181.camel@rex> (raw)
In-Reply-To: <732c81e35c4936d54c7fb495420cbb5c67c474ba.1299192495.git.sgw@linux.intel.com>

On Thu, 2011-03-03 at 14:49 -0800, Saul Wold wrote:
> From: Zhai Edwin <edwin.zhai@intel.com>
> 
> There is a tricky race condition that "Sato" icons got missing on
> matchbox-desktop as low priority "hicolor" theme was chosen. Explictly
> settting "Sato" in gtk config file to avoid this.
> 
> [BUGID #456] got fixed.
> 
> Signed-off-by: Zhai Edwin <edwin.zhai@intel.com>
> ---
>  .../sato-icon-theme/sato-icon-theme.inc            |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-sato/sato-icon-theme/sato-icon-theme.inc b/meta/recipes-sato/sato-icon-theme/sato-icon-theme.inc
> index a1669c6..0eff9dd 100644
> --- a/meta/recipes-sato/sato-icon-theme/sato-icon-theme.inc
> +++ b/meta/recipes-sato/sato-icon-theme/sato-icon-theme.inc
> @@ -16,9 +16,12 @@ PACKAGE_ARCH = "all"
>  
>  EXTRA_OECONF += "--with-iconmap=${STAGING_LIBDIR_NATIVE}/../libexec/icon-name-mapping"
>  
> +#explictly setting "Sato" as default icon theme to avoid icon missing due to
> +#tricky race condition
>  pkg_postinst_${PN} () {
>          if [ "x$D" != "x" ]; then
>                  exit 1
>          fi
>          gtk-update-icon-cache -q /usr/share/icons/Sato
> +        echo 'gtk-icon-theme-name = "Sato"' >> /etc/gtk-2.0/gtkrc
>  }

I've deliberately merged the previous version of this patch as this one
wipes out any contents of the file! I can live with duplicate lines for
now.

I'd like the bug to remain open on this one as this is a workaround, not
a proper fix for the problem. It can change priority/target milestone
though.

Cheers,

Richard




  reply	other threads:[~2011-03-03 23:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 22:49 [PATCH 00/10] Consolidated Pull Request [v2] Saul Wold
2011-03-03 22:49 ` [PATCH 01/10] libpcre: fix the name collision with libc Saul Wold
2011-03-03 22:49 ` [PATCH 03/10] sato-icon-theme: Explictly use "Sato" as gtk icon theme Saul Wold
2011-03-03 23:24   ` Richard Purdie [this message]
2011-03-04  1:05     ` Zhai, Edwin
2011-03-03 22:49 ` [PATCH 02/10] x11vnc: Fix the start failure Saul Wold
2011-03-03 22:49 ` [PATCH 04/10] gstreamer: install the sound card driver of es1370 Saul Wold
2011-03-03 22:49 ` [PATCH 05/10] Add libtool-nativesdk for ADT Saul Wold
2011-03-03 22:49 ` [PATCH 06/10] ADT: Bug fix for Suse Linux Saul Wold
2011-03-03 22:49 ` [PATCH 08/10] recipe: add newt from OE Saul Wold
2011-03-03 22:49 ` [PATCH 07/10] recipe: add chkconfig for LSB command test Saul Wold
2011-03-03 22:49 ` [PATCH 09/10] recipe: add slang from OE Saul Wold
2011-03-03 22:49 ` [PATCH 10/10] task-poky-lsb: add chkconfig Saul Wold
2011-03-03 23:27 ` [PATCH 00/10] Consolidated Pull Request [v2] Richard Purdie
2011-03-03 23:41 ` Richard Purdie
  -- strict thread matches above, loose matches on Subject: below --
2011-03-03 20:02 [PATCH 00/10] Colsolidated Pull Request Saul Wold
2011-03-03 20:02 ` [PATCH 03/10] sato-icon-theme: Explictly use "Sato" as gtk icon theme Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299194668.17567.181.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=edwin.zhai@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox