From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mail.openembedded.org (Postfix) with ESMTP id 0EBFD78802 for ; Thu, 14 Dec 2017 18:03:42 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Dec 2017 10:03:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,400,1508828400"; d="scan'208";a="2747116" Received: from kanavin-desktop.fi.intel.com (HELO [10.237.68.161]) ([10.237.68.161]) by orsmga007.jf.intel.com with ESMTP; 14 Dec 2017 10:03:42 -0800 From: Alexander Kanavin To: Stefan Agner References: <20171213180624.30839-1-stefan@agner.ch> <56bd3e44-1478-9095-4fef-3f7453b7ec94@linux.intel.com> <74fb0f2c-574b-56be-1bba-6b859ee07029@linux.intel.com> <2e3178d0-c6eb-97f8-c524-bcee54091397@linux.intel.com> <37d7ff0a6470bb60cf62d73585b3c3f8@agner.ch> <2ddf3fe7-20f3-87e0-969d-a0ed83cf9256@linux.intel.com> <4a6b7a11117ca59fa8b5ffd60c889387@agner.ch> <84080427-d60b-6527-b0f4-938fae379559@linux.intel.com> Message-ID: <129da6c9-63f8-c660-ec6c-d6b9ba28e480@linux.intel.com> Date: Thu, 14 Dec 2017 20:04:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Cc: Stefan Agner , openembedded-core@lists.openembedded.org Subject: Re: [RFC] opkg: avoid running postinst scripts twice when using systemd X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2017 18:03:43 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 12/14/2017 07:49 PM, Alexander Kanavin wrote: > On 12/14/2017 07:40 PM, Stefan Agner wrote: > >> Oh, I see, well that simplifies it, doesn't it? E.g. >> >>      # If package managers support postinsts and the package manager is >> present on the >>      # rootfs, then it will handle postinsts just fine, no need to deploy >> scripts again. >>      if delayed_postinsts and not runtime_pkgmanage: >>          self._save_postinsts() >> >> And with that it will be as it used to be before the above commit, and >> the way it should be. > > Sorry, but no. You are making an implicit assumption about how rpmrootfs > child class behaves here, which is not a good thing to do in a parent > class. What you *can* do however is move the "and not runtime_pkgmanage" check into the child classes for opkg and dpkg. I'm fine with that. Alex