From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 28/46] xorg-lib: inherit gettext class instead of adding gettext to DEPENDS directly
Date: Mon, 04 Apr 2011 13:00:49 +0100 [thread overview]
Message-ID: <1301918449.24596.345.camel@rex> (raw)
In-Reply-To: <89bd2dfb441de55bbac4e7588ba4ef4ffde35913.1301631488.git.raj.khem@gmail.com>
On Thu, 2011-03-31 at 21:29 -0700, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-graphics/xorg-lib/libxau_1.0.6.bb | 2 +-
> meta/recipes-graphics/xorg-lib/libxdmcp_1.1.0.bb | 2 --
> meta/recipes-graphics/xorg-lib/xorg-lib-common.inc | 2 +-
> meta/recipes-graphics/xorg-lib/xtrans_1.2.6.bb | 1 -
> 4 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-graphics/xorg-lib/libxau_1.0.6.bb b/meta/recipes-graphics/xorg-lib/libxau_1.0.6.bb
> index 79078ef..c96b6e9 100644
> --- a/meta/recipes-graphics/xorg-lib/libxau_1.0.6.bb
> +++ b/meta/recipes-graphics/xorg-lib/libxau_1.0.6.bb
> @@ -9,7 +9,7 @@ require xorg-lib-common.inc
> LICENSE = "MIT-style"
> LIC_FILES_CHKSUM = "file://COPYING;md5=7908e342491198401321cec1956807ec"
>
> -DEPENDS += " xproto gettext"
> +DEPENDS += " xproto"
> PROVIDES = "xau"
>
> PR = "r0"
> diff --git a/meta/recipes-graphics/xorg-lib/libxdmcp_1.1.0.bb b/meta/recipes-graphics/xorg-lib/libxdmcp_1.1.0.bb
> index d897dab..8ac8e38 100644
> --- a/meta/recipes-graphics/xorg-lib/libxdmcp_1.1.0.bb
> +++ b/meta/recipes-graphics/xorg-lib/libxdmcp_1.1.0.bb
> @@ -17,8 +17,6 @@ PROVIDES = "xdmcp"
> PR = "r0"
> PE = "1"
>
> -DEPENDS += "gettext"
> -
> XORG_PN = "libXdmcp"
>
> BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc b/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
> index 4ed8c86..9b4ce1e 100644
> --- a/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
> +++ b/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
> @@ -11,6 +11,6 @@ SRC_URI = "${XORG_MIRROR}/individual/lib/${XORG_PN}-${PV}.tar.bz2"
>
> S = "${WORKDIR}/${XORG_PN}-${PV}"
>
> -inherit autotools pkgconfig
> +inherit autotools pkgconfig gettext
NAK. Please don't add gettext dependencies to every xorg library because
three of them require it. Please add the inherits to the individual
recipes that need it. This improves parallel build performance as some
things can start compiling before gettext is built.
Cheers,
Richard
next prev parent reply other threads:[~2011-04-04 12:03 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 4:28 [PATCH 00/46] Enhance uclibc support Khem Raj
2011-04-01 4:28 ` [PATCH 01/46] sanity.bbclass: Use SSTATE_MANIFESTS instead of hard coding sstate-control Khem Raj
2011-04-04 11:45 ` Richard Purdie
2011-04-01 4:28 ` [PATCH 02/46] classes: Use virtual/libintl instead of gettext Khem Raj
2011-04-04 11:43 ` Richard Purdie
2011-04-05 2:38 ` Tom Rini
2011-04-01 4:28 ` [PATCH 03/46] classes: Use linux-uclibceabi instead of linux-uclibgnuceabi for os portion of triplet Khem Raj
2011-04-01 4:28 ` [PATCH 04/46] site: Add mips-linux-uclibc site file and add to x86_64-linux-uclibc Khem Raj
2011-04-01 4:28 ` [PATCH 05/46] conf/distro/poky.conf: Use -uclibceabi instead of -uclibgnuceabi Khem Raj
2011-04-01 4:28 ` [PATCH 06/46] recipes: Use -uclibceabi instead of -uclibcgnueabi Khem Raj
2011-04-04 11:46 ` Richard Purdie
2011-04-01 4:28 ` [PATCH 07/46] libiconv: update from 1.9.2 -> 1.11.1 Khem Raj
2011-04-04 11:45 ` Richard Purdie
2011-04-01 4:28 ` [PATCH 08/46] avahi.inc: Conditionalize RECOMMENDS by using overrides Khem Raj
2011-04-01 4:28 ` [PATCH 09/46] galago: inherit gettext class instead of adding gettext to DEPENDS directly Khem Raj
2011-04-01 4:28 ` [PATCH 10/46] telepathy-glib_0.13.6.bb: " Khem Raj
2011-04-01 4:28 ` [PATCH 11/46] console-tools_0.3.2.bb: inherit gettext Khem Raj
2011-04-01 4:28 ` [PATCH 12/46] coreutils_6.9.bb: Remove gettext from DEPENDS Khem Raj
2011-04-01 4:28 ` [PATCH 13/46] gettext_0.17.bb: Use linux-uclibceabi instead of linux-uclibcgnueabi Khem Raj
2011-04-04 11:50 ` Richard Purdie
2011-04-01 4:28 ` [PATCH 14/46] glib-2.0: Inherit gettext should provide right libintl so remove from DEPENDS Khem Raj
2011-04-04 11:52 ` Richard Purdie
2011-04-01 4:28 ` [PATCH 15/46] util-linux.inc: remove virtual/libintl " Khem Raj
2011-04-04 11:57 ` Richard Purdie
2011-04-01 4:28 ` [PATCH 16/46] binutils: Use arm*-*-linux-uclibceabi instead of arm*-*-linux-uclibcgnueabi Khem Raj
2011-04-01 4:29 ` [PATCH 17/46] bison: Make compilable on uclibc Khem Raj
2011-04-01 4:29 ` [PATCH 18/46] diffstat_1.54.bb: inherit gettext class instead of adding gettext to DEPENDS directly Khem Raj
2011-04-01 4:29 ` [PATCH 19/46] libpam_1.1.3.bb: Fix compilation on uclibc when innetgr is absent Khem Raj
2011-04-04 11:58 ` Richard Purdie
2011-04-01 4:29 ` [PATCH 20/46] alsa-utils_1.0.23.bb: Remove xmlto requirement Khem Raj
2011-04-04 11:59 ` Richard Purdie
2011-04-01 4:29 ` [PATCH 21/46] liboil_0.3.17.bb: Enable x86_64 unaligned memory access Khem Raj
2011-04-01 4:29 ` [PATCH 22/46] e2fsprogs.inc: inherit gettext class instead of adding gettext to DEPENDS directly Khem Raj
2011-04-01 4:29 ` [PATCH 23/46] flex.inc: " Khem Raj
2011-04-04 12:30 ` Richard Purdie
2011-04-01 4:29 ` [PATCH 24/46] elfutils_0.148.bb: Fix compilation issues on uclibc Khem Raj
2011-04-04 12:30 ` Richard Purdie
2011-04-01 4:29 ` [PATCH 25/46] gcc-runtime_4.5.1.bb: Do not filter out -feliminate-dwarf2-dups Khem Raj
2011-04-04 12:36 ` Richard Purdie
2011-04-01 4:29 ` [PATCH 26/46] perl_5.12.2.bb: By defualt undefine features not found in uclibc Khem Raj
2011-04-04 12:36 ` Richard Purdie
2011-04-01 4:29 ` [PATCH 27/46] xorg-proto: inherit gettext class instead of adding gettext to DEPENDS directly Khem Raj
2011-04-04 12:36 ` Richard Purdie
2011-04-01 4:29 ` [PATCH 28/46] xorg-lib: " Khem Raj
2011-04-04 12:00 ` Richard Purdie [this message]
2011-04-01 4:29 ` [PATCH 29/46] attr: Fix compilation on uclibc Khem Raj
2011-04-04 12:38 ` Richard Purdie
2011-04-01 4:29 ` [PATCH 30/46] sed: inherit gettext class instead of adding gettext to DEPENDS directly Khem Raj
2011-04-01 4:29 ` [PATCH 31/46] chkconfig_1.3.49.bb: " Khem Raj
2011-04-01 4:29 ` [PATCH 32/46] libuser_0.57.1.bb: " Khem Raj
2011-04-01 4:29 ` [PATCH 33/46] libzypp_git.bb: " Khem Raj
2011-04-01 4:30 ` [PATCH 34/46] xz_5.0.0.bb: " Khem Raj
2011-04-01 4:30 ` [PATCH 35/46] gdk-pixbuf_2.22.1.bb: " Khem Raj
2011-04-01 4:30 ` [PATCH 36/46] libgdata_0.7.1.bb: " Khem Raj
2011-04-01 4:30 ` [PATCH 37/46] popt_1.16.bb: " Khem Raj
2011-04-01 4:30 ` [PATCH 38/46] libgpg-error: " Khem Raj
2011-04-01 4:30 ` [PATCH 39/46] clutter.inc: " Khem Raj
2011-04-01 4:30 ` [PATCH 40/46] libxcb.inc: Replace XCBPROTO_XCBPYTHONDIR to point to staging area Khem Raj
2011-04-01 4:30 ` [PATCH 41/46] util-macros_1.11.0.bb: inherit gettext class instead of adding gettext to DEPENDS directly Khem Raj
2011-04-01 4:30 ` [PATCH 42/46] gstreamer_0.10.31.bb: " Khem Raj
2011-04-01 4:30 ` [PATCH 43/46] gnutls.inc: " Khem Raj
2011-04-01 4:30 ` [PATCH 44/46] libcap.inc: Pass SYSTEM_HEADERS to make Khem Raj
2011-04-01 4:30 ` [PATCH 45/46] libexif_0.6.16.bb: inherit gettext class instead of adding gettext to DEPENDS directly Khem Raj
2011-04-04 12:43 ` Richard Purdie
2011-04-01 4:30 ` [PATCH 46/46] linux-tools.inc: Dummify do_compile_perf and do_install_perf for uclibc Khem Raj
2011-04-03 23:46 ` Khem Raj
2011-04-04 12:49 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301918449.24596.345.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox