Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/3] cmake: add support for oe qt4 tools names
Date: Wed, 11 May 2011 16:17:03 +0100	[thread overview]
Message-ID: <1305127023.30391.374.camel@rex> (raw)
In-Reply-To: <1305039119-1469-3-git-send-email-otavio@ossystems.com.br>

On Tue, 2011-05-10 at 14:51 +0000, Otavio Salvador wrote:
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  meta/recipes-devtools/cmake/cmake-native_2.8.3.bb  |    2 +-
>  meta/recipes-devtools/cmake/cmake.inc              |    3 +-
>  .../cmake/cmake/support-oe-qt4-tools-names.patch   |   90 ++++++++++++++++++++
>  3 files changed, 93 insertions(+), 2 deletions(-)
>  create mode 100644 meta/recipes-devtools/cmake/cmake/support-oe-qt4-tools-names.patch

This looks ok but could you please give more details in the patch about
why its needed. Saul should be able to point you at the details of where
that information is.

Cheers,

Richard




  reply	other threads:[~2011-05-11 15:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10 14:51 [PATCH 1/3] cmake.bbclass: fix qmake and rpath issues Otavio Salvador
2011-05-10 14:51 ` [PATCH 2/3] qmake_base.bbclass: add generate_qt_config_file task Otavio Salvador
2011-05-11 15:16   ` Richard Purdie
2011-05-10 14:51 ` [PATCH 3/3] cmake: add support for oe qt4 tools names Otavio Salvador
2011-05-11 15:17   ` Richard Purdie [this message]
2011-05-12  1:11     ` Otavio Salvador
2011-05-10 19:59 ` [PATCH 1/3] cmake.bbclass: fix qmake and rpath issues Saul Wold
2011-05-10 20:04   ` Otavio Salvador
2011-05-11 15:14     ` Richard Purdie
2011-05-11 15:15 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305127023.30391.374.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox