From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: LIC_FILES_CHKSUM fatal?
Date: Mon, 16 May 2011 20:57:22 +0100 [thread overview]
Message-ID: <1305575842.3424.105.camel@rex> (raw)
In-Reply-To: <1305563063.2429.65.camel@phil-desktop>
On Mon, 2011-05-16 at 17:24 +0100, Phil Blundell wrote:
> This change, from commit d2d5456cd3b3bd3e52a5dedccca4d46e3a7986d1:
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 225530a..71ed5b6 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -349,7 +349,7 @@ def package_qa_check_license(workdir, d):
> # just throw a warning now. Once licensing data in entered for enough of the recipes,
> # this will be converted into error and False will be returned.
> bb.error(pn + ": Recipe file does not have license file information (LIC_FILES_CHKSUM)")
> - return True
> + return False
>
> means that, contrary to what the comment says, lack of LIC_FILES_CHKSUM
> is now a fatal error. Was this a deliberate change or an oversight?
>
It was a deliberate change, the comment was missed in the change though.
Yes, its annoying and we can have some way to turn it off but for at
least the core, having them present is a good thing.
Cheers,
Richard
next prev parent reply other threads:[~2011-05-16 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 16:24 LIC_FILES_CHKSUM fatal? Phil Blundell
2011-05-16 19:57 ` Richard Purdie [this message]
2011-05-16 20:05 ` Gary Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305575842.3424.105.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox