From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] rootfs_ipk: respect ONLINE_PACKAGE_MANAGEMENT
Date: Thu, 19 May 2011 11:15:03 +0100 [thread overview]
Message-ID: <1305800103.3424.464.camel@rex> (raw)
In-Reply-To: <1305733061.18415.98.camel@lenovo.internal.reciva.com>
On Wed, 2011-05-18 at 16:37 +0100, Phil Blundell wrote:
> On Tue, 2011-05-17 at 17:22 +0100, Richard Purdie wrote:
> > On Tue, 2011-05-17 at 15:50 +0100, Phil Blundell wrote:
> > > I guess I could teach remove_packaging_data_files() to not create the
> > > empty directory if O_P_M=="none". Would you be happier with that?
> >
> > Mostly. The question remains what happens if there are postinstalls that
> > are expecting to run on the device. I'm guessing that is why the mkdir
> > is there since at present we don't want to break the postinstalls.
>
> The comment says something about ensuring that the lock directory
> exists, presumably for future invocations of opkg. I guess this is to
> support O_P_M="add" kind of semantics.
>
> As far as I know there's no other reason that postinsts should
> expect/require the opkg directory to exist. So I think it should
> probably be safe just to delete it if O_P_M="none".
Let me put this another way:
We have postinstalls that require to run on the target device. If
they're present, we need opkg there to run them, or at least some kind
of script to handle that and I think both cases have a requirement on
that directory (the rpm backend has a suitable script).
So the current patches which just don't create it don't really address
the problem. At the very least the image generation should error if
these types of postinstall are present which I guess is my real concern.
Cheers,
Richard
next prev parent reply other threads:[~2011-05-19 10:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 13:55 [PATCH] rootfs_ipk: respect ONLINE_PACKAGE_MANAGEMENT Phil Blundell
2011-05-17 14:24 ` Richard Purdie
2011-05-17 14:50 ` Phil Blundell
2011-05-17 16:22 ` Richard Purdie
2011-05-18 15:37 ` Phil Blundell
2011-05-19 10:15 ` Richard Purdie [this message]
2011-05-19 10:31 ` Phil Blundell
2011-05-19 11:21 ` Richard Purdie
2011-05-19 11:41 ` Phil Blundell
2011-05-19 12:16 ` Richard Purdie
2011-05-19 15:04 ` Phil Blundell
2011-05-19 15:08 ` Richard Purdie
2011-05-24 13:59 ` Phil Blundell
2011-05-24 14:12 ` Richard Purdie
2011-05-24 14:16 ` Phil Blundell
2011-05-19 16:58 ` Chris Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305800103.3424.464.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox