From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCHv2 2/3] distcc_2.18.3.bb: Fix compilation on uclibc
Date: Fri, 20 May 2011 12:50:05 +0100 [thread overview]
Message-ID: <1305892205.3424.596.camel@rex> (raw)
In-Reply-To: <d95f77d22bbe7bf5718516f667b3e1433757c861.1305849572.git.raj.khem@gmail.com>
On Thu, 2011-05-19 at 17:02 -0700, Khem Raj wrote:
> We enable gtk/gnome in distcc that code uses loadavg()
> a function unimplemented in uclibc. Therefore for uclibc
> we disable gnome and gtk+ features in distcc
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-devtools/distcc/distcc_2.18.3.bb | 15 ++++++++++-----
> 1 files changed, 10 insertions(+), 5 deletions(-)
As Phil mentions, uclibc should probably be the exception here, not
glibc. I've therefore not taken it yet to see if we can come up with
anything better...
Cheers,
Richard
> diff --git a/meta/recipes-devtools/distcc/distcc_2.18.3.bb b/meta/recipes-devtools/distcc/distcc_2.18.3.bb
> index 1f5c2af..e73ce16 100644
> --- a/meta/recipes-devtools/distcc/distcc_2.18.3.bb
> +++ b/meta/recipes-devtools/distcc/distcc_2.18.3.bb
> @@ -6,7 +6,8 @@ LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
> PR = "r6"
>
> -DEPENDS = "avahi gtk+"
> +DEPENDS = "avahi"
> +DEPENDS_append-libc-glibc = " gtk+ "
> RRECOMMENDS_${PN} = "avahi-daemon"
>
> # Upstream change this patch periodically so store locally
> @@ -24,17 +25,21 @@ inherit autotools pkgconfig update-rc.d
>
> INITSCRIPT_NAME = "distcc"
>
> -EXTRA_OECONF = " --with-gtk "
> -
> +EXTRA_OECONF_libc-glibc = " --with-gtk "
> +EXTRA_OECONF_libc-uclibc = " --without-gtk --without-gnome "
> do_install_append() {
> install -d ${D}${sysconfdir}/init.d/
> install -d ${D}${sysconfdir}/default
> install -m 0755 ${WORKDIR}/distcc ${D}${sysconfdir}/init.d/
> install -m 0755 ${WORKDIR}/default ${D}${sysconfdir}/default/distcc
> + ${DESKTOPINSTALL}
> +}
> +DESKTOPINSTALL = ""
> +DESKTOPINSTALL_libc-glibc () {
> + install -d ${D}${datadir}/distcc/
> install -m 0644 ${WORKDIR}/distccmon-gnome.desktop ${D}${datadir}/distcc/
> }
> -
> -PACKAGES += "distcc-distmon-gnome"
> +PACKAGES_append_libc-glibc = " distcc-distmon-gnome"
>
> FILES_${PN} = " ${sysconfdir} \
> ${bindir}/distcc \
next prev parent reply other threads:[~2011-05-20 11:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 0:02 [PATCHv2 0/3] Fix recipes to build with uclibc Khem Raj
2011-05-20 0:02 ` [PATCHv2 1/3] uclibc/site_config/funcs: getloadavg is unimplemented Khem Raj
2011-05-20 0:02 ` [PATCHv2 2/3] distcc_2.18.3.bb: Fix compilation on uclibc Khem Raj
2011-05-20 7:03 ` Phil Blundell
2011-05-20 11:50 ` Richard Purdie [this message]
2011-05-20 0:02 ` [PATCHv3 3/3] nfs-utils_1.2.3.bb: Fix compile failure " Khem Raj
2011-05-20 15:20 ` [PATCHv2 0/3] Fix recipes to build with uclibc Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305892205.3424.596.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox