Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] opkg-utils: Allow uppercase lettlers in package names
Date: Fri, 20 May 2011 16:01:47 +0100	[thread overview]
Message-ID: <1305903707.2525.29.camel@phil-desktop> (raw)
In-Reply-To: <1305873952.18415.249.camel@lenovo.internal.reciva.com>

On Fri, 2011-05-20 at 07:45 +0100, Phil Blundell wrote:
> On Thu, 2011-05-19 at 14:09 -0700, Khem Raj wrote:
> > Some packages have uppercase letters in their names e.g.
> > efikamx kernel. We allow uppercase character with
> > uppercase-letters.patch
> 
> This is not a good idea.  Uppercase characters have never been permitted
> in .deb/.ipk. 
> 
> Isn't legitimize_package_name() crunching them to lower case for you?
> If not then I think it should be made to do that.

I just checked the code and it certainly looks like it should be doing
that:

	# Remaining package name validity fixes
	return s.lower().replace('_', '-').replace('@', '+').replace(',', '+').replace('/', '-')

So if that isn't working for you then I think it needs a bit of
debugging.

p.





  reply	other threads:[~2011-05-20 15:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 21:09 [PATCH 0/2] Let opkg-build allow uppercase letters Khem Raj
2011-05-19 21:09 ` [PATCH 1/2] opkg: Synchronise with OE Khem Raj
2011-05-19 22:10   ` Richard Purdie
2011-05-19 21:09 ` [PATCH 2/2] opkg-utils: Allow uppercase lettlers in package names Khem Raj
2011-05-20  5:22   ` Frans Meulenbroeks
2011-05-20  6:45   ` Phil Blundell
2011-05-20 15:01     ` Phil Blundell [this message]
2011-05-20 15:06       ` Koen Kooi
2011-05-20 16:05       ` Andreas Oberritter
2011-05-20 16:31         ` Richard Purdie
2011-05-20 18:35         ` Khem Raj
2011-05-21  6:43           ` Koen Kooi
2011-05-19 22:07 ` [PATCH 0/2] Let opkg-build allow uppercase letters Richard Purdie
2011-05-19 23:24   ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305903707.2525.29.camel@phil-desktop \
    --to=pb@pbcl.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox