From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH] dbus 1.4.1: create UUIDDIR in postinst
Date: Fri, 27 May 2011 14:47:17 +0100 [thread overview]
Message-ID: <1306504037.2525.449.camel@phil-desktop> (raw)
In-Reply-To: <1306503625-719-1-git-send-email-koen@dominion.thruhere.net>
On Fri, 2011-05-27 at 15:40 +0200, Koen Kooi wrote:
> + mkdir -p $UUIDDIR || true
Why "|| true"? If this creation fails then the following chown will
surely fail as well, except with a different and less illuminating error
message.
> + chown "$MESSAGEUSER"."$MESSAGEUSER" "$UUIDDIR"
The dot syntax is nonstandard and obsolescent. It would be better to
use ":" there.
p.
next prev parent reply other threads:[~2011-05-27 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 13:40 [PATCH] dbus 1.4.1: create UUIDDIR in postinst Koen Kooi
2011-05-27 13:42 ` Koen Kooi
2011-05-27 13:47 ` Phil Blundell [this message]
2011-05-27 13:55 ` Koen Kooi
2011-05-27 15:13 ` Phil Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306504037.2525.449.camel@phil-desktop \
--to=pb@pbcl.net \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox