From: Joshua Lock <josh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH 00/11] Add PR service and integrate PKGV/PKGR from OE
Date: Fri, 27 May 2011 14:01:05 -0700 [thread overview]
Message-ID: <1306530065.1747.14.camel@vorpal> (raw)
In-Reply-To: <1306526949.1747.8.camel@vorpal>
From 1618318f0a30847b08c158e7ac82f9043126144e Mon Sep 17 00:00:00 2001
From: Joshua Lock <josh@linux.intel.com>
Date: Fri, 27 May 2011 13:04:44 -0700
Subject: [PATCH 2/2] uievent: fix queueing of events for xmlrpc before
UI has
loaded
The change to Queue up events before the UI is spawned broke the xmlrpc
server because the uievent implementation of BBUIEventQueue expects
pickled
strings for its queue_event() method.
This is because the RPC exposed event.send() method must accept pickled
strings, but for xmlrpc event.send() is just mapped to queue_event().
Work
around this by adding a send_event method which unpickles strings and
hands
them off to queue_event() which can then be used for the remapping.
Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
lib/bb/ui/uievent.py | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/bb/ui/uievent.py b/lib/bb/ui/uievent.py
index b404805..2fef4e4 100644
--- a/lib/bb/ui/uievent.py
+++ b/lib/bb/ui/uievent.py
@@ -63,17 +63,20 @@ class BBUIEventQueue:
def queue_event(self, event):
self.eventQueueLock.acquire()
- self.eventQueue.append(pickle.loads(event))
+ self.eventQueue.append(event)
self.eventQueueNotify.set()
self.eventQueueLock.release()
+ def send_event(self, event):
+ self.queue_event(pickle.loads(event))
+
def startCallbackHandler(self):
server = UIXMLRPCServer()
self.host, self.port = server.socket.getsockname()
server.register_function( self.system_quit, "event.quit" )
- server.register_function( self.queue_event, "event.send" )
+ server.register_function( self.send_event, "event.send" )
server.socket.settimeout(1)
self.EventHandle =
self.BBServer.registerEventHandler(self.host, self.port)
--
1.7.5.1
next prev parent reply other threads:[~2011-05-27 21:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 6:31 [PATCH 00/11] Add PR service and integrate PKGV/PKGR from OE Lianhao Lu
2011-05-27 6:31 ` [PATCH 01/11] Added the PR service Lianhao Lu
2011-05-27 6:31 ` [PATCH 02/11] conf/bitbake.conf: Added variables for " Lianhao Lu
2011-05-27 6:31 ` [PATCH 03/11] meta-yocto/local.conf.sample: Added PRSERV_HOST and PRSERV_PORT Lianhao Lu
2011-05-27 6:31 ` [PATCH 04/11] classes/package(prserv).bbclass: Get PRAUTO and use PKGV/PKGR Lianhao Lu
2011-05-27 6:31 ` [PATCH 05/11] classes/package_xxx.class: Use PKGE/PKGV/PKGR Lianhao Lu
2011-05-27 6:31 ` [PATCH 06/11] udev: use EXTENDPKGV instead of EXTENDPV Lianhao Lu
2011-05-27 6:31 ` [PATCH 07/11] xcb: " Lianhao Lu
2011-05-27 6:31 ` [PATCH 08/11] xorg-proto: " Lianhao Lu
2011-05-27 6:31 ` [PATCH 09/11] xorg-util/util-macros: " Lianhao Lu
2011-05-27 6:31 ` [PATCH 10/11] linux-libc-headers: " Lianhao Lu
2011-05-27 6:31 ` [PATCH 11/11] conf/bitbake.conf: Removed EXTENDPV and EXTENDPEVER Lianhao Lu
2011-05-27 17:00 ` [PATCH 00/11] Add PR service and integrate PKGV/PKGR from OE Richard Purdie
2011-05-27 18:48 ` Koen Kooi
2011-05-27 19:08 ` Otavio Salvador
2011-05-27 19:13 ` Koen Kooi
2011-05-27 20:09 ` Joshua Lock
2011-05-27 20:24 ` Khem Raj
2011-05-27 20:54 ` Joshua Lock
2011-05-27 21:00 ` [bitbake-devel] " Joshua Lock
2011-05-27 21:01 ` Khem Raj
2011-05-27 21:09 ` Joshua Lock
2011-05-27 21:01 ` Joshua Lock
2011-05-27 21:01 ` Joshua Lock [this message]
2011-05-27 22:09 ` Richard Purdie
2011-05-28 1:02 ` Khem Raj
2011-05-28 1:05 ` Khem Raj
2011-05-28 1:34 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306530065.1747.14.camel@vorpal \
--to=josh@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox