Re: [PATCH 1/1] eglibc: migrate configurability from oe

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2011-06-03 at 10:57 +0200, Koen Kooi wrote:
> Op 3 jun 2011, om 10:22 heeft Richard Purdie het volgende geschreven:
> 
> > On Fri, 2011-06-03 at 14:47 +0800, Kang Kai wrote:
> >> From: Kang Kai <kai.kang@windriver.com>
> >> 
> >> Migrate configurability from oe, try to shrink minimal image size
> >> 
> >> The switch is in local.conf.sample, uncomment the line
> >> DISTRO_FEATURES_EGLIBC = ""
> >> and write what options you want to enable.
> >> 
> >> If want to disable locale-code charsets or locales, you have to uncomment
> >> PACKAGE_NO_GCONV = 1
> >> Because without this, it fails on package_do_split_gconvs in libc-package.bbclass
> > 
> > I have some comments:
> > 
> > a) I think these should become flags in DISTRO_FEATURES with an
> > "eglibc-" prefix so something like "spawn" would become "eglibc-spawn"
> 
> Taking a step back here, uclibc has the same configurability, so
> wouldn't it make sense to align both (where possible) and just have
> 'libc-spawn' in DISTRO_FEATURES?

If multiple libc's can support it, it would seem to make sense to have a
common option.

It would really mean a libc should complain loudly when it sees an
option it can't support though (e.g. glibc)...

Cheers,

Richard