From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QWnJW-00019s-HX for openembedded-core@lists.openembedded.org; Wed, 15 Jun 2011 12:27:10 +0200 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id p5FANjhD025488 for ; Wed, 15 Jun 2011 11:23:45 +0100 Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 25229-06 for ; Wed, 15 Jun 2011 11:23:41 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id p5FANdON025482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 15 Jun 2011 11:23:40 +0100 From: Richard Purdie To: Patches and discussions about the oe-core layer In-Reply-To: References: <1308086002-16398-1-git-send-email-raj.khem@gmail.com> <1308086688.15712.362.camel@rex> <8C2617DC-2693-42A3-810B-C3A516DB7360@dominion.thruhere.net> <3E89612B-A102-423A-8499-55E5AC1CDF07@dominion.thruhere.net> <1308132960.15712.390.camel@rex> Date: Wed, 15 Jun 2011 11:23:38 +0100 Message-ID: <1308133418.15712.396.camel@rex> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 X-Virus-Scanned: amavisd-new at rpsys.net Subject: Re: [PATCH V2] allarch.bbclass: Set FEED_ARCH to original value of BASE_PACKAGE_ARCH and then set BASE_PACKAGE_ARCH to 'all' X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2011 10:27:10 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2011-06-15 at 12:18 +0200, Koen Kooi wrote: > Op 15 jun 2011, om 12:16 heeft Richard Purdie het volgende geschreven: > > > On Wed, 2011-06-15 at 09:00 +0200, Koen Kooi wrote: > >> Op 15 jun 2011, om 01:12 heeft Khem Raj het volgende geschreven: > >> > >>> On Tue, Jun 14, 2011 at 2:44 PM, Koen Kooi wrote: > >>>> > >>>> Op 14 jun 2011, om 23:40 heeft Khem Raj het volgende geschreven: > >>>> > >>>>> On Tue, Jun 14, 2011 at 2:32 PM, Koen Kooi wrote: > >>>>>> > >>>>> BASE_PACKAGE_ARCH = "${@['armv5teb', > >>>>> 'armv5te'][bb.data.getVar('SITEINFO_ENDIANESS', d, 1) == 'le']}" > >>>>> > >>>>> PACKAGE_EXTRA_ARCHS = "${@['armeb armv4b armv4tb armv5teb', 'arm armv4 > >>>>> armv4t armv5te'][bb.data.getVar('SITEINFO_ENDIANESS', d, 1) == 'le']}" > >>>>> > >>>>> and this does not get evaluated properly then > >>>> > >>>> But that wouldn't matter in the scope of allarch, though? > >>> > >>> SITEINFO_ENDIANESS = "${@siteinfo_get_endianess(d)}" > >>> > >>> def siteinfo_get_endianess(d): > >>> info = get_siteinfo_list(d) > >>> if 'endian-little' in info: > >>> return "le" > >>> elif 'endian-big' in info: > >>> return "be" > >>> bb.error("Site info could not determine endianess for target") > >>> > >>> > >>> and > >>> get_siteinfo_list has this > >>> > >>> targetinfo = {\ > >>> "allarch-linux": "",\ > >>> > >>> hence siteinfo_get_endianess ends up with > >>> > >>> bb.error("Site info could not determine endianess for target") > >>> > >>> may be we need to differentiate with None return and empty string > >>> return along with 'endian-little' and 'endian-big' > >>> or may be add another option called 'endian-neutral' > >> > >> Or just add a bogus endianness: http://cgit.openembedded.org/cgit.cgi/meta-openembedded/commit/?id=f95ffd6cedb2a0fcad9db1b2d612663a327be87b > > > > This is just papering over cracks. "allarch" packages shouldn't be > > querying endianness, it really is that simple. > > This isn't the recipes querying the endianness, but the class itself. Er, if nothing references the appropriate variable, the query is never made... Cheers, Richard