From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: Using TCLIBC = "uclibc" in oe-core
Date: Tue, 21 Jun 2011 17:49:54 +0100 [thread overview]
Message-ID: <1308674994.20015.33.camel@rex> (raw)
In-Reply-To: <1308668047.21613.30.camel@phil-desktop>
On Tue, 2011-06-21 at 15:54 +0100, Phil Blundell wrote:
> On Tue, 2011-06-21 at 15:04 +0100, Tom Parkin wrote:
> > The attached patch allows me to (at least) assemble the bitbake task
> > list when TCLIBC = "uclibc". I'm not sure whether this is the correct
> > approach, though.
>
> Do you know why glib-2.0.inc is doing this crazy thing in the first
> place? If we're going to have code in the config files to effectively
> make it think that USE_NLS is always on, maybe that check should just be
> removed.
>
> You're right though that the current line in tclibc-uclibc.inc is
> clearly just wrong and should be either fixed or deleted.
It does appear to work due to code in base.bbclass which does:
use_nls = bb.data.getVar('USE_NLS_%s' % pn, d, 1)
if use_nls != None:
bb.data.setVar('USE_NLS', use_nls, d)
where this code predates the use of pn-${PN} in overrides.
Nowadays it makes sense just to use the pn- override and we should drop
this legacy stuff IMO.
Cheers,
Richard
next prev parent reply other threads:[~2011-06-21 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 14:04 Using TCLIBC = "uclibc" in oe-core Tom Parkin
2011-06-21 14:50 ` Khem Raj
2011-06-21 14:53 ` Mark Hatle
2011-06-21 14:54 ` Phil Blundell
2011-06-21 15:02 ` Khem Raj
2011-06-21 16:49 ` Richard Purdie [this message]
2011-06-22 13:13 ` Tom Parkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308674994.20015.33.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox