Re: [PATCH 1/1] u-boot: set SRCREV to a git revision instead of a tag reference

[Joshua Lock <josh@linux.intel.com>]

On Tue, 2011-06-21 at 18:29 +0100, Paul Eggleton wrote:
> If we use a tag here then bitbake has to connect to the repository to find
> out the corresponding revision (so it can expand SRCPV which is part of PV,
> which amongst other things is needed to determine whether or not the
> package has to be rebuilt.) This occurs at parse time; on machines behind a
> firewall or with no network access this can be a problem.
> 
> We wish to avoid unnecessary network accesses and network access in our
> default configuration during parse time is even worse. Substituting the
> git revision corresponding to the tag prevents bitbake from having to
> contact the remote repository in order to expand PV.
> 
> Addresses [YOCTO #1186]
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>

Great work tracking this down! I wonder if it's worth mentioning in the
metadata that the revision corresponds to the tag?

Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
>  meta/recipes-bsp/uboot/u-boot_2011.03.bb |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-bsp/uboot/u-boot_2011.03.bb b/meta/recipes-bsp/uboot/u-boot_2011.03.bb
> index 07f0609..25af69b 100644
> --- a/meta/recipes-bsp/uboot/u-boot_2011.03.bb
> +++ b/meta/recipes-bsp/uboot/u-boot_2011.03.bb
> @@ -12,9 +12,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb \
>  
>  FILESDIR = "${@os.path.dirname(bb.data.getVar('FILE',d,1))}/u-boot-git/${MACHINE}"
>  
> -SRCREV = "v2011.03"
> +SRCREV = "19b54a701811220221fc4d5089a2bb18892018ca"
>  PV = "v2011.03+git${SRCPV}"
> -PR="r4"
> +PR = "r5"
>  
>  SRC_URI = "git://git.denx.de/u-boot.git;branch=master;protocol=git"
>  

-- 
Joshua Lock
        Yocto Build System Monkey
        Intel Open Source Technology Centre