Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [RFC PATCH 3/5] linux-kernel-base: add support for Linux 3.x
Date: Wed, 22 Jun 2011 11:22:36 +0100	[thread overview]
Message-ID: <1308738156.21613.80.camel@phil-desktop> (raw)
In-Reply-To: <BANLkTinkNcN8RBcZapj5xF=q_p4O++trgg@mail.gmail.com>

On Tue, 2011-06-21 at 21:10 +0200, Anders Darander wrote:
> If we keep the kernel_majorversion, we'll need to have something
> similar to this,
> as the major version up to 2.6 was determined by X.Y. From 3.0, only the first
> digit represents the major number; while the second digit (0 in 3.0)
> is equal to
> x in 2.6.x. Thus, the function to determine the major version has to
> return either
> 2.6 or 3.

Well, the thing is that OE's "kernelmajorversion" was always something
of an artificial construct.  It was introduced purely as a way of coping
with some of the differences between 2.4 and 2.6: this was primarily the
different module format, but it also happened to coincide with major
rewrites of the iPAQ and Zaurus kernels which were the main ones we were
using in OE at the time.  Returning "3" here isn't going to be helpful
since none of the classes will know what to do with that value: all they
ever do is compare it against either 2.4 or 2.6.  The exact form of
those tests has never been standardised, so there is a risk that you
might encounter

if [ "$KERNEL_MAJORVERSION" != "2.6" ]; then
  # must be 2.4!
fi

which would evidently lose quite badly if the major version were
suddenly to become 3.

Since there are no material differences between Linux 2.6 and Linux 3.0
that OE needs to be aware of, I think it would make most sense for
kernelmajorversion() to continue returning "2.6" for Linux 3.0 and
future versions if we did want to keep that mechanism.

However, since the whole purpose of the mechanism was to ease the
transition from 2.4 to 2.6, I am fairly confident that it can just be
deleted altogether if support for 2.4 is being removed. 

p.





  reply	other threads:[~2011-06-22 10:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21 18:18 [RFC PATCH 0/5] Linux 3.0 build support Anders Darander
2011-06-21 18:18 ` [RFC PATCH 1/5] Remove support for building 2.4 kernels Anders Darander
2011-06-21 18:47   ` Phil Blundell
2011-06-21 19:05     ` Anders Darander
2011-06-21 18:18 ` [RFC PATCH 2/5] module-init-tools-cross: add provides for depmod-3 Anders Darander
2011-06-21 18:22   ` Koen Kooi
2011-06-21 18:40     ` Anders Darander
2011-06-21 18:46   ` Phil Blundell
2011-06-21 19:03     ` Anders Darander
2011-06-22  5:49       ` Anders Darander
2011-06-21 18:18 ` [RFC PATCH 3/5] linux-kernel-base: add support for Linux 3.x Anders Darander
2011-06-21 18:45   ` Phil Blundell
2011-06-21 19:10     ` Anders Darander
2011-06-22 10:22       ` Phil Blundell [this message]
2011-06-22 10:41         ` Anders Darander
2011-06-21 18:18 ` [RFC PATCH 4/5] modutils-initscripts: move recipe prior to modutils removal Anders Darander
2011-06-21 18:18 ` [RFC PATCH 5/5] modutils: remove modutils Anders Darander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308738156.21613.80.camel@phil-desktop \
    --to=pb@pbcl.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox