Re: [RFC v3 PATCH 0/9] Linux 3.0 build support

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2011-06-29 at 20:02 +0200, Anders Darander wrote:
> On Wed, Jun 29, 2011 at 19:54, Anders Darander <anders@chargestorm.se> wrote:
> >
> > v3: - task-base.bb: fix a problem that *pcmia26 couldn't be found.
> 
> This third version fixes a bug introduced in v2. (task-base-pcmcia26
> weren't found). The fix is incorporated in patch 0008 (task-base).
> 
> Sofar, I've only got positive feedback on v2. (some feedback off-list
> (including some that probably should have been on-list if it hadn't
> been for some gmane problems).
> 
> Unless I find some more problems, or get such reports, I plan to send
> a pull request towards the end of this week.

It looks good to me apart from some ordering and PR bump type issues. 

Where you change the depmod dependency for example, we really need to
rebuild module-init-tools at the same time so the binary changes name at
the right point in the series. Patch 4 and patch 2 therefore probably
need to be together with a PR bump. I also wondered what the patch to
module-init-tools you're removing does (and why you just disabled rather
than deleted it).

Looks good though! I'm trying to resist merging some of the standalone
bits straight away :)

Cheers,

Richard