From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] busybox: bump PR to enable largefile support
Date: Fri, 01 Jul 2011 10:59:48 +0100 [thread overview]
Message-ID: <1309514388.2633.36.camel@phil-desktop> (raw)
In-Reply-To: <1aa106d547c9e10d025a011922335cc3ea1bbb69.1309513694.git.dexuan.cui@intel.com>
On Fri, 2011-07-01 at 17:53 +0800, Dexuan Cui wrote:
> In the previous commit we enable largefile setting in
> meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to
> actually enable it.
I guess this would be a good case for using something like OE .dev's
DISTRO_PR. It would be a bit sad if we end up having to bump PRs all
over the place in oe-core whenever some random layer changes its
DISTRO_FEATURES or whatever.
Also, just on a stylistic issue, it's a bit confusing to talk about "the
previous commit" if the commit in question was to a different file and
in a different repo. If you want to refer to a specific commit it's
best to mention the actual hash and, if necessary, the repo where it can
be found.
p.
next prev parent reply other threads:[~2011-07-01 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 9:53 [PATCH 0/1] busybox: bump PR to enable largefile support Dexuan Cui
2011-07-01 9:53 ` [PATCH 1/1] " Dexuan Cui
2011-07-01 9:59 ` Phil Blundell [this message]
2011-07-01 14:10 ` Cui, Dexuan
2011-07-01 9:56 ` [PATCH 0/1] " Cui, Dexuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309514388.2633.36.camel@phil-desktop \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox