From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v4 7/8] task-base: remove modutils reference.
Date: Fri, 01 Jul 2011 23:37:32 +0100 [thread overview]
Message-ID: <1309559852.20015.568.camel@rex> (raw)
In-Reply-To: <8E04AE3A-0304-4771-A3F9-C00EA0451205@dominion.thruhere.net>
On Fri, 2011-07-01 at 14:05 +0200, Koen Kooi wrote:
> Op 1 jul 2011, om 13:52 heeft Anders Darander het volgende geschreven:
>
> >
> > * Koen Kooi Koen Kooi <koen@dominion.thruhere.net> [07/01/11 09:20 AM]:
> >> Op 1 jul 2011, om 09:06 heeft Anders Darander het volgende geschreven:
> >>> Also remove the other kernel24 references.
> >>> Make everything dependent on kernel26 default.
> >>
> >> Since there will be only one of each, can we just completely scrap there
> >> variables and put the items directly in the tasks?
> >
> > Sure, we could do that.
> >
> > One question though, how should I treat
> >
> > RRECOMMENDS_task-base-kernel26 = "\
> > kernel-module-nls-utf8 \
> > kernel-module-input \
> > kernel-module-uinput \
> > kernel-module-rtc-dev \
> > kernel-module-rtc-proc \
> > kernel-module-rtc-sysfs \
> > kernel-module-rtc-sa1100 \
> > kernel-module-unix"
> >
> > from task-base.bb? Should that part just be new, general
> > RRECOMMENDS = "\
> > kernel-module-nls-utf8 \
> > kernel-module-input \
> > kernel-module-uinput \
> > kernel-module-rtc-dev \
> > kernel-module-rtc-proc \
> > kernel-module-rtc-sysfs \
> > kernel-module-rtc-sa1100 \
> > kernel-module-unix"?
> >
> > I guess that's the right thing, and I'll create a new pull request with that
> > merged into the last patch.
>
> The above is what I had in mind, but I do question the need for
> rtc-sa1100 in task-base, that should be in the machine.conf as
> MACHINE_EXTRA_RRECOMMENDS or so. But that is outside the scope of this
> patch I guess.
Agreed, rtc-sa1100 shouldn't be there and I don't know how that
happened :/. I'll take patches to resolve that.
Cheers,
Richard
next prev parent reply other threads:[~2011-07-01 22:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 7:05 [PATCH v4 0/8] Linux 3.0 build support Anders Darander
2011-07-01 7:06 ` [PATCH v4 1/8] Remove support for building 2.4 kernels Anders Darander
2011-07-01 7:06 ` [PATCH v4 2/8] image¡kernel.bblass module-init-tools: do not use depmod-2.6 Anders Darander
2011-07-01 7:06 ` [PATCH v4 3/8] modules-init-tools(-cross): update to 3.16 Anders Darander
2011-07-01 7:06 ` [PATCH v4 4/8] kernel.bblass: remove get_kernelmajorversion Anders Darander
2011-07-01 7:06 ` [PATCH v4 5/8] modutils-initscripts: move recipe prior to modutils removal Anders Darander
2011-07-01 7:06 ` [PATCH v4 6/8] modutils: remove modutils Anders Darander
2011-07-01 7:06 ` [PATCH v4 7/8] task-base: remove modutils reference Anders Darander
2011-07-01 7:20 ` Koen Kooi
2011-07-01 11:52 ` Anders Darander
2011-07-01 12:05 ` Koen Kooi
2011-07-01 22:37 ` Richard Purdie [this message]
2011-07-01 12:07 ` Anders Darander
2011-07-01 7:06 ` [PATCH v4 8/8] distro_tracking_fields: remove modutils Anders Darander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309559852.20015.568.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox