Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Anders Darander <anders@chargestorm.se>
Subject: Re: [PATCH 1/1] kernel.bbclass: make external module compile
Date: Tue, 05 Jul 2011 13:44:05 +0100	[thread overview]
Message-ID: <1309869846.2410.3.camel@phil-desktop> (raw)
In-Reply-To: <406427a001cfa7c1859f54147b678f0ef647a922.1309867242.git.anders@chargestorm.se>

On Tue, 2011-07-05 at 14:01 +0200, Anders Darander wrote:
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 943252a..26ee416 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -149,7 +149,6 @@ kernel_do_install() {

        #
        # We don't want to leave host-arch binaries in /sysroots, so
        # we clean the scripts dir while leaving the generated config

>  	# and include files.
>  	#
>  	oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean
> -	make -C $kerneldir _mrproper_scripts
>  	find $kerneldir -path $kerneldir/scripts -prune -o -name "*.[csS]" -exec rm '{}' \;
>  	find $kerneldir/Documentation -name "*.txt" -exec rm '{}' \;

Did you verify that this doesn't introduce any new QA warnings during
packaging?  Presumably that line was originally added for a reason and
it seems a bit surprising that just deleting it without any replacement
is the right thing to do.

Also, if the scripts dir isn't being cleaned anymore, I guess the
preceding comment should be adjusted to match the new reality.

p.





  reply	other threads:[~2011-07-05 12:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 12:01 [PATCH 0/1] Fix external module compilations Anders Darander
2011-07-05 12:01 ` [PATCH 1/1] kernel.bbclass: make external module compile Anders Darander
2011-07-05 12:44   ` Phil Blundell [this message]
2011-07-05 12:54     ` Anders Darander
2011-07-05 13:09       ` Richard Purdie
2011-07-05 15:04         ` Anders Darander
2011-07-06 16:37           ` Darren Hart
2011-07-06 17:31             ` Anders Darander
2011-07-06 18:22               ` Darren Hart
2011-07-08 13:31                 ` Anders Darander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309869846.2410.3.camel@phil-desktop \
    --to=pb@pbcl.net \
    --cc=anders@chargestorm.se \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox