From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Qe7tJ-00080n-5f for openembedded-core@lists.openembedded.org; Tue, 05 Jul 2011 17:50:25 +0200 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id p65FkaVZ000399 for ; Tue, 5 Jul 2011 16:46:36 +0100 Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 32302-10 for ; Tue, 5 Jul 2011 16:46:32 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id p65FkU3k000393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 5 Jul 2011 16:46:31 +0100 From: Richard Purdie To: openembedded-core Date: Tue, 05 Jul 2011 16:45:59 +0100 Message-ID: <1309880759.20015.724.camel@rex> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 X-Virus-Scanned: amavisd-new at rpsys.net Subject: [PATCH 1/2] kernel-yocto: Fix case where recipe is always reparsed X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2011 15:50:25 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit If you include a bitbake variable as a comment in a shell function then it gets expanded by the bitbake signature handling code. This could be classed as a bug or a feature depending on your viewpoint (e.g. a multiline variable included in a comment could actually contain executable code). Since we don't always want kernel-yocto to reparse this changes the syntax of the comment so it doesn't trigger the problem. Signed-off-by: Richard Purdie --- meta/classes/kernel-yocto.bbclass | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass index 536434f..98272fc 100644 --- a/meta/classes/kernel-yocto.bbclass +++ b/meta/classes/kernel-yocto.bbclass @@ -136,7 +136,7 @@ do_validate_branches() { return fi - # nothing to do if SRCREV=${AUTOREV} + # nothing to do if SRCREV is AUTOREV if [ "${SRCREV_machine}" = "AUTOINC" ]; then # restore the branch for builds git checkout -f ${KBRANCH}