From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 02/17] connman: Package unpackaged .la file
Date: Wed, 06 Jul 2011 11:34:37 +0100 [thread overview]
Message-ID: <1309948477.20015.776.camel@rex> (raw)
In-Reply-To: <1309943646.6337.5.camel@phil-desktop>
On Wed, 2011-07-06 at 10:14 +0100, Phil Blundell wrote:
> On Tue, 2011-07-05 at 23:51 +0100, Richard Purdie wrote:
> > +FILES_${PN}-dev += "${libdir}/connman/plugins/*.la"
>
> Actually, in this specific case, I think adding *.la to FILES is the
> wrong thing to do. The DSOs in question are plugins, not libraries, and
> nobody is ever going to link against them. So the corresponding .la
> files (and the .so symlinks, if those are also getting created) really
> are just dross and should be deleted.
Ever is a strong word, you might want to wrap and customise a plugin or
something :)
Seriously, I'm in two minds on this and had patches both ways. In the
end I decided it was less ugly to package them than have the metadata
covered in .la file deletions which would likely encourage people to
delete library .la files too and not see the subtle difference.
There are also rumours that some libltdl derived plugin modules use
the .la files under certain circumstances. I suspect connman doesn't use
libltdl but I didn't check. I also suspect that if it did need them, the
standard package would need to include them. Since it presumably works
as is, it therefore mustn't need them. Its a useful thing to keep in
mind though since plugins doesn't necessarily mean no need for the .la
files (imagemagik was software that used the .la files for plugins
iirc).
Cheers,
Richard
next prev parent reply other threads:[~2011-07-06 10:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 22:51 [PATCH 00/17] Various QA/unpackaged files cleanups Richard Purdie
2011-07-05 22:51 ` [PATCH 01/17] gcc: Fix unpackaged files warnings, broken symlink and superfluous files Richard Purdie
2011-07-05 22:51 ` [PATCH 02/17] connman: Package unpackaged .la file Richard Purdie
2011-07-06 9:14 ` Phil Blundell
2011-07-06 10:34 ` Richard Purdie [this message]
2011-07-05 22:51 ` [PATCH 03/17] tslib: " Richard Purdie
2011-07-05 22:51 ` [PATCH 04/17] btrfs-tools: Fix manpage creation directory Richard Purdie
2011-07-05 22:51 ` [PATCH 05/17] xcb-proto: Package unshipped files, create python-xcbgen package for python xcbgen code Richard Purdie
2011-07-05 22:51 ` [PATCH 06/17] eds-dbus: Package unpackaged files Richard Purdie
2011-07-05 22:51 ` [PATCH 07/17] systemtap: Don't set prefix to a path including so examples get placed in the correct path and packaged correctly Richard Purdie
2011-07-05 22:51 ` [PATCH 08/17] qt4: Package debug source files Richard Purdie
2011-07-05 22:51 ` [PATCH 09/17] telepathy-python: Remove unneeded and unpackaged files Richard Purdie
2011-07-05 22:51 ` [PATCH 10/17] librsvg: Clean up " Richard Purdie
2011-07-05 22:51 ` [PATCH 11/17] gtk-engines: Package " Richard Purdie
2011-07-05 22:51 ` [PATCH 12/17] x11perf: Packaged " Richard Purdie
2011-07-05 22:51 ` [PATCH 13/17] apt: Package " Richard Purdie
2011-07-06 9:17 ` Phil Blundell
2011-07-06 10:25 ` Richard Purdie
2011-07-05 22:51 ` [PATCH 14/17] git: Package up python and gitweb files into appropriate packages Richard Purdie
2011-07-05 22:51 ` [PATCH 15/17] kernelshark/trace-cmd: Clean up QA warnings including fising LDFLAGS issues Richard Purdie
2011-07-06 9:15 ` Phil Blundell
2011-07-05 22:51 ` [PATCH 16/17] opensp: Add unpackaged files Richard Purdie
2011-07-05 22:51 ` [PATCH 17/17] chrpath: Ensure the package respects the docdir variable Richard Purdie
2011-07-06 2:59 ` [PATCH 00/17] Various QA/unpackaged files cleanups Otavio Salvador
2011-07-06 8:03 ` Richard Purdie
2011-07-06 9:06 ` Phil Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309948477.20015.776.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox