From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 46/50] mesa-xlib: Dont use locales with uclibc
Date: Wed, 20 Jul 2011 11:14:07 +0100 [thread overview]
Message-ID: <1311156848.30326.58.camel@phil-desktop> (raw)
In-Reply-To: <4fb98dee67ddcdbc35f6e5c203ddb7217cd55a97.1311150183.git.sgw@linux.intel.com>
On Wed, 2011-07-20 at 01:28 -0700, Saul Wold wrote:
> +We disable locale on uclibc in OE therefore we do not use it if building for uclibc
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +Upstream-Status: Inappropriate <OE config related>
> +
> + {
> +-#if defined(_GNU_SOURCE) && !defined(__CYGWIN__) && !defined(__FreeBSD__)
> ++#if defined(_GNU_SOURCE) && !defined(__CYGWIN__) && !defined(__FreeBSD__) && !defined(__UCLIBC__)
I'm not totally thrilled about having the equivalence between "uclibc"
and "no locale" patched into random sources in a piecemeal way like
this. uClibc doesn't inherently lack locale support, it's just that the
default oe-core configuration happens to turn it off, and there's no
reason that another layer mightn't decide to enable it again. It would
suck if that layer then had to re-patch all these recipes to take the
__UCLIBC__ conditional back out.
I think it would be better to replace this sort of thing with an
autoconf linker test that checks to see whether newlocale() is actually
available in the installed libc.
p.
next prev parent reply other threads:[~2011-07-20 10:18 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 8:27 [PATCH 00/50] Major Update for Uclibc and gcc4.5.1 Saul Wold
2011-07-20 8:27 ` [PATCH 01/50] alsa-tools: Fix recipe build error Saul Wold
2011-07-20 8:27 ` [PATCH 02/50] Revert "libiconv: add version 1.13.1" Saul Wold
2011-07-20 8:27 ` [PATCH 03/50] libiconv: Add recipes for 1.13.1 Saul Wold
2011-07-20 14:14 ` Richard Purdie
2011-07-20 18:06 ` Khem Raj
2011-07-20 8:27 ` [PATCH 04/50] scripts/contrib: add build time regression test script Saul Wold
2011-07-20 8:27 ` [PATCH 05/50] libpng: upgrade to v1.2.46 Saul Wold
2011-07-20 8:27 ` [PATCH 06/50] distro-tracking: update libpng Saul Wold
2011-07-20 8:27 ` [PATCH 07/50] xcb-proto: add multilib support Saul Wold
2011-08-03 4:27 ` Kumar Gala
2011-07-20 8:27 ` [PATCH 08/50] pciutils: Change the hardcoded /usr/lib to support multilib Saul Wold
2011-07-20 8:27 ` [PATCH 09/50] udev: Change hard coded " Saul Wold
2011-07-20 14:27 ` Richard Purdie
2011-07-20 8:27 ` [PATCH 10/50] perl: revise the RRECOMMENDS_perl-modules for multilib case Saul Wold
2011-07-20 8:27 ` [PATCH 11/50] uclibc: improve packaging granularity Saul Wold
2011-07-20 8:27 ` [PATCH 12/50] gdk-pixbuf(-native): Fix build by disabling introspection Saul Wold
2011-07-20 8:28 ` [PATCH 13/50] metacity: Add gnome-doc-utils to DEPENDS Saul Wold
2011-07-20 8:28 ` [PATCH 14/50] gnome-doc-utils: Package up python site packages, bump PR Saul Wold
2011-07-20 8:28 ` [PATCH 15/50] iptuils: Add sgmlspl-native to DEPENDS Saul Wold
2011-07-20 8:28 ` [PATCH 16/50] btrfs-tools: Add util-linux " Saul Wold
2011-07-20 8:28 ` [PATCH 17/50] gcc: Add gcc configure for PowerPC e500v2/SPE embedded floating point ABI Saul Wold
2011-07-20 8:28 ` [PATCH 18/50] tclibc-*libc: Utilize TARGET_FPU for gnuspe setting Saul Wold
2011-07-20 8:28 ` [PATCH 19/50] tune-ppce500v2: Add a tune file for PowerPC e500v2 cores Saul Wold
2011-07-20 8:28 ` [PATCH 20/50] openssl: Add handling for linux-gnuspe-powerpc Saul Wold
2011-07-20 8:28 ` [PATCH 21/50] flac: fix build issues with e500v2 (gnuspe) toolchain Saul Wold
2011-07-20 8:28 ` [PATCH 22/50] tune-ppce500mc: Add a tune file for PowerPC e500mc core Saul Wold
2011-07-20 8:28 ` [PATCH 23/50] gcc_4.5.1: fix arm_bswapsi2.patch Saul Wold
2011-07-20 8:28 ` [PATCH 24/50] gcc_4.5.1: add pr43810.patch Saul Wold
2011-07-20 8:28 ` [PATCH 25/50] gcc_4.5.1: add pr44290.patch Saul Wold
2011-07-20 8:28 ` [PATCH 26/50] gcc_4.5.1: add pr44606.patch Saul Wold
2011-07-20 8:28 ` [PATCH 27/50] gcc_4.5.1: add pr45094.patch Saul Wold
2011-07-20 8:28 ` [PATCH 28/50] gcc_4.5.1: add pr45052.patch Saul Wold
2011-07-20 8:28 ` [PATCH 29/50] gcc_4.5.1: add pr45886.patch Saul Wold
2011-07-20 8:28 ` [PATCH 30/50] bitbake.conf, sanity.bbclass: Drop mercurial-native Saul Wold
2011-07-20 8:28 ` [PATCH 31/50] help2man-native: Add 1.38.2 Saul Wold
2011-07-20 8:28 ` [PATCH 32/50] autotools.bbclass: Add help2man-native to the main DEPENDS tree Saul Wold
2011-07-20 8:28 ` [PATCH 33/50] default-distrovars: Add largefile and argp to DISTRO_FEATURES Saul Wold
2011-07-20 8:28 ` [PATCH 34/50] acl, attr: Fix build failures when NLS is disabled on uclibc Saul Wold
2011-07-20 8:28 ` [PATCH 35/50] classes/gettext: Do not disable nls for non target recipes Saul Wold
2011-07-20 8:28 ` [PATCH 36/50] libxdamage, libxft, libxrandr: Add missing dependency on virtual/libx11 Saul Wold
2011-07-20 8:28 ` [PATCH 37/50] tzcode,tzdata: Update tzdata to 2011h Saul Wold
2011-07-20 8:28 ` [PATCH 38/50] task-core-x11-sato: Add empty NETWORK_MANAGER for uclibc Saul Wold
2011-07-20 8:28 ` [PATCH 39/50] uclibc_0.9.32: Implement sync_file_range2 Saul Wold
2011-07-20 9:04 ` Phil Blundell
2011-07-20 8:28 ` [PATCH 40/50] oprofile: Fix build when query_module is not there Saul Wold
2011-07-20 8:28 ` [PATCH 41/50] powertop: Add lintl to linker commandline on uclibc Saul Wold
2011-07-20 8:28 ` [PATCH 42/50] pimlico/dates: Fix build " Saul Wold
2011-07-20 9:06 ` Phil Blundell
2011-07-20 8:28 ` [PATCH 43/50] binutils: Fix build when compiling target binutils recipe with gcc 4.6 Saul Wold
2011-07-20 8:28 ` [PATCH 44/50] clutter-box2d: Replace use of finite macro with C99 compliant isfinite() Saul Wold
2011-07-20 8:28 ` [PATCH 45/50] sysprof: Define NT_GNU_BUILD_ID if undefined Saul Wold
2011-07-20 8:28 ` [PATCH 46/50] mesa-xlib: Dont use locales with uclibc Saul Wold
2011-07-20 10:14 ` Phil Blundell [this message]
2011-07-20 14:15 ` Richard Purdie
2011-07-20 18:07 ` Khem Raj
2011-07-20 8:28 ` [PATCH 47/50] mesa-dri: Fix build on uclibc Saul Wold
2011-07-20 8:28 ` [PATCH 48/50] task-core-tools: Exclude systemtap for uclibc Saul Wold
2011-07-20 8:28 ` [PATCH 49/50] site/x86_64-linux-uclibc: Cache lf_cv_sane_realloc Saul Wold
2011-07-20 8:28 ` [PATCH 50/50] pseudo: fix uninitialised variable in realpath_fix.patch Saul Wold
2011-07-20 14:28 ` [PATCH 00/50] Major Update for Uclibc and gcc4.5.1 Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311156848.30326.58.camel@phil-desktop \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox