From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] glib-2.0: fix a compilation issue due to dtrace
Date: Thu, 21 Jul 2011 17:00:29 +0100 [thread overview]
Message-ID: <1311264030.30326.140.camel@phil-desktop> (raw)
In-Reply-To: <3a3c12b31f8d8dc600750be9d75aeeb236c5b618.1311240498.git.nitin.a.kamble@intel.com>
On Thu, 2011-07-21 at 02:29 -0700, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Could you add some text to the commit message explaining what the
compilation issue was and under what circumstances it occurred? It
might also be good to know why bumping PR isn't necessary.
Also:
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.28.8.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.28.8.bb
> index a2e609f..7d095c1 100644
> --- a/meta/recipes-core/glib-2.0/glib-2.0_2.28.8.bb
> +++ b/meta/recipes-core/glib-2.0/glib-2.0_2.28.8.bb
> @@ -19,4 +19,3 @@ SRC_URI[md5sum] = "789e7520f71c6a4bf08bc683ec764d24"
> SRC_URI[sha256sum] = "222f3055d6c413417b50901008c654865e5a311c73f0ae918b0a9978d1f9466f"
>
> BBCLASSEXTEND = "native"
> -
... I guess this part of the patch can be omitted.
p.
next prev parent reply other threads:[~2011-07-21 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 9:29 [PATCH 0/2] Misc Fixes nitin.a.kamble
2011-07-21 9:29 ` [PATCH 1/2] python: fix security vulnerability nitin.a.kamble
2011-07-21 18:55 ` Khem Raj
2011-07-22 3:32 ` Kamble, Nitin A
2011-07-21 9:29 ` [PATCH 2/2] glib-2.0: fix a compilation issue due to dtrace nitin.a.kamble
2011-07-21 15:57 ` Koen Kooi
2011-07-21 16:00 ` Phil Blundell [this message]
2011-07-21 16:38 ` Kamble, Nitin A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311264030.30326.140.camel@phil-desktop \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox