Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] classes/image_types: IMAGE_TYPES was missing some entries
Date: Tue, 26 Jul 2011 15:30:17 +0100	[thread overview]
Message-ID: <1311690617.2344.251.camel@rex> (raw)
In-Reply-To: <4E2EC9D5.9070209@mentor.com>

On Tue, 2011-07-26 at 07:06 -0700, Tom Rini wrote:
> On 07/25/2011 09:21 PM, Joshua Lock wrote:
> > Some of these entries are required by the GUI to enable the expected workflow
> > of the ADT, namely a compressed rootfs image.
> > 
> > Signed-off-by: Joshua Lock <josh@linux.intel.com>
> > ---
> >  meta/classes/image_types.bbclass |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> > index 1108802..f1aef86 100644
> > --- a/meta/classes/image_types.bbclass
> > +++ b/meta/classes/image_types.bbclass
> > @@ -103,4 +103,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
> >  IMAGE_DEPENDS_ubifs = "mtd-utils-native"
> >  
> >  # This variable is available to request which values are suitable for IMAGE_FSTYPES
> > -IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi"
> > +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"
> 
> So, is there some way we can do this dynamically?  Either oe-core is
> missing ext4, or we'll have to add that and all it's permutations.  And
> then there's u-boot signed copies of all of the ext* compressed versions.

The configs for the image types could do something like:

IMAGE_TYPE += "jffs2"
IMAGE_CMD_jffs2 = "xxx"

or we could switch to the syntax:

IMAGE_CMD[jffs2] = "xxx"

?

Cheers,

Richard






  reply	other threads:[~2011-07-26 14:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-26  4:21 [PATCH 0/1] Add remaining types to IMAGE_TYPES Joshua Lock
2011-07-26  4:21 ` [PATCH 1/1] classes/image_types: IMAGE_TYPES was missing some entries Joshua Lock
2011-07-26 14:06   ` Tom Rini
2011-07-26 14:30     ` Richard Purdie [this message]
2011-07-26 14:53   ` Richard Purdie
2011-07-26 16:03     ` Joshua Lock
2011-07-26 16:09       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311690617.2344.251.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox