From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QlqtS-0002JC-Rb for openembedded-core@lists.openembedded.org; Wed, 27 Jul 2011 01:18:31 +0200 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id p6QN18Sp025326 for ; Wed, 27 Jul 2011 00:01:08 +0100 Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 23667-09 for ; Wed, 27 Jul 2011 00:01:04 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id p6QN12gl025320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 27 Jul 2011 00:01:03 +0100 From: Richard Purdie To: Patches and discussions about the oe-core layer In-Reply-To: References: <1311692251.2344.262.camel@rex> Date: Wed, 27 Jul 2011 00:00:53 +0100 Message-ID: <1311721253.2344.320.camel@rex> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 X-Virus-Scanned: amavisd-new at rpsys.net Subject: Re: [PATCH 1/1] license.bbclass: Splitting out licenses X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2011 23:18:31 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2011-07-26 at 08:15 -0700, Flanagan, Elizabeth wrote: > On Tue, Jul 26, 2011 at 7:57 AM, Richard Purdie > wrote: > > On Mon, 2011-07-25 at 16:24 -0700, Flanagan, Elizabeth wrote: > >> Adding a bit more functionality here: > >> 1. Adding some more SPDX Maps to take care of + licenses > >> 2. Strip out -native and -cross package license wrangling. > >> If it doesn't go on the image, we shouldn't wrangle it. > >> 3. Split out the license destination directory to a > >> IMAGE_NAME time stamped dir in > >> /tmp/deploy/licenses/${IMAGE_NAME}/ > >> > >> I've removed the handler from my previous Pull as license > >> manifest needs more discussion and I don't want these > >> bug fixes to be held up by an added feature. > > > > I obviously don't understand this code :/ > > > > What happens when I run "bitbake core-image-minimal core-image-sato", > > i.e. when I build two images in one build? > > > > I suspect this current approach is flawed and we actually need to > > postprocess the installed package list after do_rootfs completes at > > image generation time to build the *real* list based on the installed > > packages? > > > > Yes. I've found that this approach is definitely flawed. It works > great for a single image build. Outside of that it acts funny, like > you mentioned and can return incorrect results. I'm planning on > revisting this soon. > > I'm suspecting that your suggested approach is the way it'll have to > be. Looking at what is generated by various runs and I see issues. > > > This code is obviously still needed as it would provide the basis so the > > code can get the licenses it needs to pull together... > > Yes, agreed. So with this in mind, where does that put this pull request? :) Cheers, Richard