From: Kumar Gala <galak@kernel.crashing.org>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] libzypp: Fix variable substitution problem in do_archgen step
Date: Thu, 28 Jul 2011 13:09:50 -0500 [thread overview]
Message-ID: <1311876590-20157-1-git-send-email-galak@kernel.crashing.org> (raw)
The do_archgen step creates a script that utilizes the variable name
${ARCH}. However, we also utilize and define ${ARCH} so instead of
having the following in the script:
COMPAT_WITH="${ARCH},${COMPAT} $COMPAT_WITH"
We get something like:
COMPAT_WITH="powerpc,${COMPAT} $COMPAT_WITH"
Just renaming the variable in the script to not conflict with ${ARCH}
fixes the issue.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
meta/recipes-extended/libzypp/libzypp_git.bb | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-extended/libzypp/libzypp_git.bb b/meta/recipes-extended/libzypp/libzypp_git.bb
index 6555bd4..a9ed639 100644
--- a/meta/recipes-extended/libzypp/libzypp_git.bb
+++ b/meta/recipes-extended/libzypp/libzypp_git.bb
@@ -111,9 +111,9 @@ do_archgen () {
shift ; continue;;
esac
if [ "${AVOID_CONSTRUCTOR}" != "true" ]; then
- ARCH="_$1"
+ CARCH="_$1"
else
- ARCH="IdString(\"$1\")"
+ CARCH="IdString(\"$1\")"
fi
shift
COMPAT=""
@@ -129,7 +129,7 @@ do_archgen () {
COMPAT="${arch_val},$COMPAT"
fi
done
- COMPAT_WITH="${ARCH},${COMPAT} $COMPAT_WITH"
+ COMPAT_WITH="${CARCH},${COMPAT} $COMPAT_WITH"
done
for each_compat in ${COMPAT_WITH} ; do
echo " defCompatibleWith( ${each_compat} );" >> zypp/poky-arch.h
--
1.7.3.4
next reply other threads:[~2011-07-28 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 18:09 Kumar Gala [this message]
2011-08-02 16:50 ` [PATCH] libzypp: Fix variable substitution problem in do_archgen step Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311876590-20157-1-git-send-email-galak@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox