From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Commits to master in my absence
Date: Mon, 01 Aug 2011 14:45:33 +0100 [thread overview]
Message-ID: <1312206333.2344.456.camel@rex> (raw)
I'm a little frustrated to see what happened when I was away from a
couple of days. I thought we'd agreed we'd queue up patches in a branch
and then I'd take care of things when I got back.
I appreciate a serious bug was then found and a fix was committed
against what I thought was agreed. This then opened the gates and more
patches were merged with decreasing severity and in the end something
got added which is just plain broken :(.
The problematic patch is:
http://git.openembedded.org/cgit.cgi/openembedded-core/commit/?id=e23f9ce928353c9da2b9c4bfa9a1a125a7d160f2
and I've commented in emails elsewhere against the various attempts to
further "fix" this.
I *really* need people to step up and start thinking about quality and
the long term impact of changes rather than just X fixes bug Y which I'm
hitting right now. This is particularly true if anyone wants to step
into the position of doing final commit merging. You *have* to take the
time to fully understand and review the changes you're adding and
consider the big picture.
I'm really hoping that I can find people who I can share the final
review/commit responsibility with but until people stop presenting me
patches which I have to reject we're not going to get the point where
they can work in that role :(.
This is particularly frustrating since I've seen people push patches
they know to be lacking in quality just because they were running low on
time and hoped they might get away with it.
Cheers,
Richard (a bit disappointed)
next reply other threads:[~2011-08-01 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 13:45 Richard Purdie [this message]
2011-08-01 17:59 ` Commits to master in my absence Khem Raj
2011-08-01 19:25 ` Tom Rini
2011-08-01 19:56 ` Richard Purdie
2011-08-01 20:18 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312206333.2344.456.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox