From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs
Date: Tue, 02 Aug 2011 16:19:54 +0100 [thread overview]
Message-ID: <1312298395.4325.53.camel@phil-desktop> (raw)
In-Reply-To: <1312272881-15695-1-git-send-email-galak@kernel.crashing.org>
On Tue, 2011-08-02 at 03:14 -0500, Kumar Gala wrote:
> +-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
> ++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'
Have you discussed that with upstream? If not, are you confident that
preferring cpio will not simply mean that we are swapping one deficiency
for another?
> +Index: automake-1.11.1/Makefile.in
> +===================================================================
> +--- automake-1.11.1.orig/Makefile.in
> ++++ automake-1.11.1/Makefile.in
> +@@ -44,7 +44,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/a
> + $(top_srcdir)/m4/missing.m4 $(top_srcdir)/m4/mkdirp.m4 \
> + $(top_srcdir)/m4/options.m4 $(top_srcdir)/m4/runlog.m4 \
> + $(top_srcdir)/m4/sanity.m4 $(top_srcdir)/m4/strip.m4 \
> +- $(top_srcdir)/m4/substnot.m4 $(top_srcdir)/m4/tar.m4 \
> ++ $(top_srcdir)/m4/substnot.m4 \
> + $(top_srcdir)/configure.ac
> + am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
> + $(ACLOCAL_M4)
Can you explain why this hunk is necessary?
> +do_configure () {
> + touch ${S}/Makefile.in
> + autotools_do_configure
> +}
... and this one?
Also, your patch is missing a Signed-off-by line. See:
http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines#Patch_Headers_and_Commit_Messages
p.
next prev parent reply other threads:[~2011-08-02 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 8:14 [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs Kumar Gala
2011-08-02 10:09 ` Richard Purdie
2011-08-02 15:09 ` Khem Raj
2011-08-02 15:19 ` Phil Blundell [this message]
2011-08-02 15:34 ` Tom Rini
2011-08-02 15:35 ` Tom Rini
2011-08-02 16:01 ` Kumar Gala
2011-08-02 16:04 ` Tom Rini
2011-08-02 16:08 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312298395.4325.53.camel@phil-desktop \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox