Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] image-mklibs.bbclass: Add powerpc64 arch support
Date: Wed, 03 Aug 2011 17:53:59 +0100	[thread overview]
Message-ID: <1312390439.2344.706.camel@rex> (raw)
In-Reply-To: <1312349222-27254-1-git-send-email-galak@kernel.crashing.org>

On Wed, 2011-08-03 at 00:27 -0500, Kumar Gala wrote:
> powerp64 dynamic loader is 'ld64.so.1'.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> * Use correct name of ppc64 dynamic loader
> * user ${baselib} so if we are /lib or /lib64 things work
> 
>  meta/classes/image-mklibs.bbclass |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/image-mklibs.bbclass b/meta/classes/image-mklibs.bbclass
> index 9f5a4ea..83f609c 100644
> --- a/meta/classes/image-mklibs.bbclass
> +++ b/meta/classes/image-mklibs.bbclass
> @@ -19,6 +19,9 @@ mklibs_optimize_image_doit() {
>  		powerpc | mips | microblaze )
>  			dynamic_loader="/lib/ld.so.1"
>  			;;
> +		powerpc64)
> +			dynamic_loader="/${baselib}/ld64.so.1"
> +			;;
>  		x86_64)
>  			dynamic_loader="/lib/ld-linux-x86-64.so.2"
>  			;;

Can we use ${base_libdir} there please?

${baselib} is really intended only for use to build the other
expressions.

We should probably use ${base_libdir} elsewhere in this file too. I also
suspect prelinking of a multilib image may need work :/.

Cheers,

Richard




  reply	other threads:[~2011-08-03 16:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03  5:27 [PATCH v2] image-mklibs.bbclass: Add powerpc64 arch support Kumar Gala
2011-08-03 16:53 ` Richard Purdie [this message]
2011-08-04  4:03   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312390439.2344.706.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox