From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: populate_sdk: We need to ensure that the SDK sysroot reflects PACKAGE_ARCH
Date: Wed, 10 Aug 2011 14:23:51 +0100 [thread overview]
Message-ID: <1312982631.14274.379.camel@rex> (raw)
In-Reply-To: <1312981676.14274.376.camel@rex>
On Wed, 2011-08-10 at 14:07 +0100, Richard Purdie wrote:
> On Wed, 2011-08-10 at 07:59 -0500, Kumar Gala wrote:
> > On Aug 9, 2011, at 11:00 PM, Lu, Lianhao wrote:
> >
> > > Richard Purdie wrote on 2011-08-10:
> > >> If we don't do this, the SDK target sysroot is named generically even
> > >> when it contains package architecture specific optimisations.
> > >>
> > >> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> ---
> > >> diff --git a/meta/classes/populate_sdk.bbclass
> > >> b/meta/classes/populate_sdk.bbclass index 0f3591b..8c19e83 100644 ---
> > >> a/meta/classes/populate_sdk.bbclass +++
> > >> b/meta/classes/populate_sdk.bbclass @@ -5,7 +5,7 @@ SDK_DIR =
> > >> "${WORKDIR}/sdk"
> > >> SDK_OUTPUT = "${SDK_DIR}/image"
> > >> SDK_DEPLOY = "${TMPDIR}/deploy/sdk"
> > >> -SDKTARGETSYSROOT = "${SDKPATH}/sysroots/${TARGET_SYS}"
> > >> +SDKTARGETSYSROOT = "${SDKPATH}/sysroots/${MULTIMACH_TARGET_SYS}"
> > >
> > > In gcc-configure-sdk.inc, it is set "--with-sysroot=${SDKPATH}/sysroots/${TARGET_SYS}".
> > > Is there any inconsistency?
> >
> > Binutils might also need updating.
>
> This is an interesting question. We certainly compile in a default path
> for the sysroot but we in general always override it from the
> environment anyway.
>
> As long as the package architectures for the sdk components are correct
> we should be able to update the defaults. I've not yet checked that
> though.
This is something which gets built into
gcc-cross-canadian-${TARGET_ARCH} (i.e i586/armpowerpc). Since we use
the target libs (inc libgcc) and everything in that package is multiple
platform enabled, I think the current behaviour is correct. It might
point an an invalid default sysroot but its up to the package
architecture specific environment files to correct that. This means the
one toolchain can be shared over multiple package architectures.
I'm open to other views of that but I think what we have there is
correct and should work with the above change.
Cheers,
Richard
next prev parent reply other threads:[~2011-08-10 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 17:57 populate_sdk: We need to ensure that the SDK sysroot reflects PACKAGE_ARCH Richard Purdie
2011-08-10 4:00 ` Lu, Lianhao
2011-08-10 12:59 ` Kumar Gala
2011-08-10 13:07 ` Richard Purdie
2011-08-10 13:23 ` Richard Purdie [this message]
2011-08-10 13:34 ` Gary Thomas
2011-08-10 13:40 ` Richard Purdie
2011-08-10 13:48 ` Gary Thomas
2011-08-10 14:23 ` Kumar Gala
2011-08-17 15:44 ` Gary Thomas
2011-09-05 19:45 ` Richard Purdie
2011-08-10 12:53 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312982631.14274.379.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox