From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 93-97-173-237.zone5.bethere.co.uk ([93.97.173.237] helo=tim.rpsys.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Qsx6R-0008Ja-TT for openembedded-core@lists.openembedded.org; Mon, 15 Aug 2011 15:21:16 +0200 Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id p7FDGZAu017133; Mon, 15 Aug 2011 14:16:35 +0100 Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 16444-05; Mon, 15 Aug 2011 14:16:31 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id p7FDGRrs017127 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 15 Aug 2011 14:16:28 +0100 From: Richard Purdie To: Patches and discussions about the oe-core layer In-Reply-To: <4E491589.3030000@linux.intel.com> References: <73BE3575-4FA5-4C20-9476-A36B9A5422D7@dominion.thruhere.net> <4E491589.3030000@linux.intel.com> Date: Mon, 15 Aug 2011 14:16:25 +0100 Message-ID: <1313414185.14274.576.camel@rex> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 X-Virus-Scanned: amavisd-new at rpsys.net Cc: Koen Kooi Subject: Re: [PATCH 1/1] gcc-cross-intermediate: revise the 64bithack.patch for multilib case X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2011 13:21:16 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2011-08-15 at 20:48 +0800, Yu Ke wrote: > On 2011/8/15 1:31, Koen Kooi wrote: > > > > Op 14 aug. 2011, om 15:32 heeft Yu Ke het volgende geschreven: > > > >> current gcc-cross-intermediate has build failure in qemux86-64 lib64 > >> multilib case. the reason is that it still use lib instead of lib64 > >> while do_install use the libdir i.e. lib64 > >> > >> so this patch fix this issue by making gcc honour the libdir. > >> > >> CC: Kumar Gala > >> CC: Richard Purdie > >> > >> Signed-off-by: Yu Ke > >> --- > >> meta/recipes-devtools/gcc/gcc-4.6.inc | 2 +- > >> meta/recipes-devtools/gcc/gcc-4.6/64bithack.patch | 16 +++++++++------- > > > > wouldn't gcc 4.5 need a similar change? > > yes, gcc 4.5 should also has this change. I will sent out another patch > for this. Please take a look at: http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rpurdie/ml4&id=4de8e0e9c286ff64f1b7fd2e695fe2d62fdadfbd I've updated the patch header and ensured that whichever compiler options are used, the compiler works as expected and also applied this to mips and pcc. Could you also please open a bug about target gcc multilib as mentioned in the patch header (targeted at post 1.1). > just curious question, what is gcc 4.5 for, since gcc 4.6 is already there? Some people are still using gcc 4.5 for various reasons. It is getting to the point we should probably move that to meta-oe though? Cheers, Richard