Re: fontconfig-2.8.0/fix_pkgconfig.patch

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2011-08-15 at 17:48 +0100, Phil Blundell wrote:
> Does anybody know where this patch came from or what it is supposed to
> be achieving?  As far as I have been able to tell with some limited git
> archaeology, it seems to have originated from Poky in the
> fontconfig-2.6.0 sort of timeframe but that's about all I have been able
> to find out.
> 
> The actual content of the patch is:
> 
> -Libs.private: @LIBXML2_LIBS@ @EXPAT_LIBS@ @FREETYPE_LIBS@ @ICONV_LIBS@
> +Libs.private: @LIBXML2_LIBS@ @EXPAT_LIBS@ -L{libdir} -lfreetype @ICONV_LIBS@
> 
> ... which, as far as I can tell, is just completely bogus.  The added
> "-L{libdir}" is causing cmake to blow up if it tries to inspect the
> private libs for fontconfig to anything that depends on it: it's
> arguably a bug in cmake that it can't tolerate {} there, but it seems
> fairly clear that this patch in its current form can't be producing any
> useful effect.

The 2.6.0-2.8.0 upgrade seems to have lost the $ character but that was
a year ago.

I have some vague memory about autotools doing something nasty to @bar@
replacements containing shell variables like ${libdir} so this could
have been to work around that as otherwise you end up with libdir
hardcoded in to the file in an expanded form.

Assuming autotools does put something sensible into the file, it can
likely be dropped now.

Cheers,

Richard