Re: [PATCH 2/2] qemu: Make qemu buildable inside qemux86/qemuppc target

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2011-08-16 at 14:32 +0800, Zhai, Edwin wrote:
> On Mon, Aug 15, 2011 at 10:25:49PM +0800, Richard Purdie wrote:
> > 
> > The patch is fine but could we change this to something like:
> > 
> > # Only use the GL passthrough patches for native/nativesdk versions
> > $QEMUGLPATCHES = "\
> >     file://qemu-git-qemugl-host.patch \
> >     file://fix-nogl.patch \
> >     file://qemugl-allow-glxcontext-release.patch \
> >     file://init-info.patch \
> >     file://enable-i386-linux-user.patch \
> >     file://qemugl-fix.patch \
> >     file://opengl-sdl-fix.patch \
> >     "
> > 
> > SRC_URI_append_virtclass-native = "\
> >     ${QEMUGLPATCHES} \
> >     "
> > 
> > SRC_URI_append_virtclass-nativesdk = "\
> >     ${QEMUGLPATCHES} \
> >     file://glflags.patch \
> >     "
> > 
> > which is just a little bit neater. Also, no need for the commented out
> > line.
> 
> RP,
> Thanks for your comments. I have modified it. Pls. pull @ same branch:
> 
> git://git.pokylinux.org/poky-contrib gzhai/master2
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=gzhai/master2
> 
> BTW, I saw qemugl_git.bb is extended as "nativesdk", and was curious about it as 
> qemugl is hacked libgl inside qemu guest, thus should not be related to "native" 
> case. Any reason? Meet the dependency requirement?

I've merged this, thanks.

We need the GL code in nativesdk since this ships as part of the SDK/ADT
toolchain and we want the GL pass through support there.

Cheers,

Richard