From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [CONSOLIDATED PULL 26/32] procps: Fix lib path to support multilib
Date: Fri, 19 Aug 2011 09:18:46 -0500 [thread overview]
Message-ID: <1313763526.13995.98.camel@rex> (raw)
In-Reply-To: <b3827be03af9e8a6041d012a3be59c9c6a818250.1313700595.git.sgw@linux.intel.com>
On Thu, 2011-08-18 at 13:55 -0700, Saul Wold wrote:
> From: Dongxiao Xu <dongxiao.xu@intel.com>
>
> Remove the install.patch which hardcode the lib paths.
> Change ${PN} to ${BPN} in file names.
>
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> ---
> .../procps/procps-3.2.8/install.patch | 29 --------------------
> meta/recipes-extended/procps/procps.inc | 3 +-
> meta/recipes-extended/procps/procps_3.2.8.bb | 8 +++---
> 3 files changed, 5 insertions(+), 35 deletions(-)
> delete mode 100644 meta/recipes-extended/procps/procps-3.2.8/install.patch
>
> diff --git a/meta/recipes-extended/procps/procps-3.2.8/install.patch b/meta/recipes-extended/procps/procps-3.2.8/install.patch
> deleted file mode 100644
> index b52a2c9..0000000
> --- a/meta/recipes-extended/procps/procps-3.2.8/install.patch
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -Upstream-Status: Inappropriate [configuration]
> -
> ---- procps-3.2.5.virgin/Makefile 2005-01-26 05:55:26.000000000 +0100
> -+++ procps-3.2.5/Makefile 2005-08-03 04:55:26.346984488 +0200
> -@@ -30,7 +30,10 @@
> - install := install -D --owner 0 --group 0
> -
> - # Lame x86-64 /lib64 and /usr/lib64 abomination:
> --lib64 := lib$(shell [ -d /lib64 ] && echo 64)
> -+# lib64 := lib$(shell [ -d /lib64 ] && echo 64)
> -+
> -+# Equally lame hack to work around makefile lameness when the host arch is 64bit, but the target is not.
> -+lib64 := lib
Both these cases are plain wrong. We can't simply drop this patch since
we may be building 64 bit on a 32 bit system and /lib64 may not exist.
Dropping the patch will therefore fix some cases and break others (e.g.
what a about x32?).
We likely need to heavier patch the Makefile.
Cheers,
Richard
next prev parent reply other threads:[~2011-08-19 14:23 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 20:55 [CONSOLIDATED PULL 00/32] Various Fixes, Updates Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 01/32] image.bbclass, kernel.bbclass: create warning file about deleting deploydir files Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 02/32] sanity.bbclass: add optional untested host distro warning Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 03/32] qt4: allow a reduction in build time Saul Wold
2011-08-19 14:34 ` Richard Purdie
2011-08-18 20:55 ` [CONSOLIDATED PULL 04/32] glib-2.0: explicitly disable dtrace and systemtap for native varaint Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 05/32] tcl: fix networking breakage Saul Wold
2011-08-19 14:31 ` Richard Purdie
2011-08-18 20:55 ` [CONSOLIDATED PULL 06/32] perl-native: Update find_perl to find the perl wrapper Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 07/32] busybox: Change ${PN} to ${BPN} in file names Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 08/32] sysvinit: " Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 09/32] qemu: modify search paths for libgl Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 10/32] scripts/runqemu: " Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 11/32] mtd-utils: Added recipe of newer version 1.4.4 Saul Wold
2011-08-19 14:28 ` Richard Purdie
2011-08-18 20:55 ` [CONSOLIDATED PULL 12/32] libxkbcommon: new Saul Wold
2011-08-19 14:27 ` Richard Purdie
2011-08-19 14:33 ` Phil Blundell
2011-08-19 14:40 ` Martin Jansa
2011-08-19 16:08 ` Richard Purdie
2011-08-18 20:55 ` [CONSOLIDATED PULL 13/32] libxslt: fix packaging of static libraries Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 14/32] at: make at usable for common user Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 15/32] conf, recipes: Redefine LINKER_HASH_STYLE Saul Wold
2011-08-19 9:24 ` Phil Blundell
2011-08-19 14:26 ` Richard Purdie
2011-08-19 15:27 ` Khem Raj
2011-08-19 16:13 ` Richard Purdie
2011-08-19 16:35 ` Khem Raj
2011-08-18 20:55 ` [CONSOLIDATED PULL 16/32] gcc-4.6: Use --with-linker-hash-style configure option Saul Wold
2011-08-19 16:23 ` Phil Blundell
2011-08-19 18:29 ` Khem Raj
2011-08-19 18:55 ` Khem Raj
2011-08-18 20:55 ` [CONSOLIDATED PULL 17/32] task-core-tools: Use LTTNGUST variable instead of hardcoding lttng-ust Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 18/32] gdb: Add lttng-ust to DEPENDS only for eglibc Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 19/32] task-core-boot: allow distribution to override default dev_manager provider with VIRTUAL-RUNTIME_dev_manager Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 20/32] bluez4: update recipe from meta-oe Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 21/32] initrdscripts: fix init-live.sh Saul Wold
2011-08-22 4:30 ` Tom Zanussi
2011-08-18 20:55 ` [CONSOLIDATED PULL 22/32] curl: Use BPN instead of PN for style like lib${PN} Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 23/32] ea-acl: " Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 24/32] attr: " Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 25/32] acl: " Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 26/32] procps: Fix lib path to support multilib Saul Wold
2011-08-19 14:18 ` Richard Purdie [this message]
2011-08-18 20:55 ` [CONSOLIDATED PULL 27/32] eglibc: check dependencies among eglibc options Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 28/32] mailx: update license and distro tracking fileds Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 29/32] slang: add homepage and update distro tracking fields Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 30/32] alsa-tools: update license and add " Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 31/32] newt: update " Saul Wold
2011-08-18 20:55 ` [CONSOLIDATED PULL 32/32] file: new file version 5.07 Saul Wold
2011-08-19 16:14 ` [CONSOLIDATED PULL 00/32] Various Fixes, Updates Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313763526.13995.98.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox